← Back to issue list

fix: make project directory loading less strict.

View original Github issue

Metadata

Project
craft-application
Number
#229
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a change to relax project directory loading validation. Commands like init can now accept non-existent directories, only failing if an existing one is incompatible. Approved by three reviewers, passed CI, and modified two files.

Suggested action:

No scores available.

Issue body

Some commands (e.g. `init`) might want to provide a project directory but not require it to exist. In these cases, we should only fail if what exists already is incompatible. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a change to relax project directory loading validation. Commands like init can now accept non-existent directories, only failing if an existing one is incompatible. Approved by three reviewers, passed CI, and modified two files.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to relax project directory loading validation. Commands such as init can now proceed without an existing directory, only failing if an existing directory is incompatible. This resolves test failures in charmcraft.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1367 fix: make application handle a nonexistent project dir charmcraft merged Merged a fix enabling the application to handle nonexistent project directories. Approved by two reviewers and dependent on PR #1364. Changes span 35 files with 989 additions and 252 deletions.
76%
#857 fix(Application): allow loading the project from another dir craft-application merged Merged fix allowing the application to load a project from a different directory. Approved by three reviewers, passed all CI checks, and merged with 49 additions and 10 deletions across four files.
74%
#1592 fix(cli): restrict --project-dir to init and pack commands (#1565) charmcraft merged Merged to main as a cherry-pick, restricting the --project-dir CLI flag to init and pack commands. Approved by two reviewers, the update removes 579 lines across eight files.
72%
#1565 fix(cli): --project-dir should only be available for init and pack commands charmcraft merged Merged a fix restricting the --project-dir CLI flag to only init and pack commands. The change removed the global flag, cleaned up tests, and reduced code by nearly 600 lines. Approved by reviewers and passed all CI checks.
72%
#238 feat!: remove optional project commands craft-application merged Merged changes removing optional project commands to enforce explicit project requirements. Approved by two reviewers and passing CI. Reverts #213 while retaining relevant tests.
71%
#276 fix: show better error when project file is missing craft-application merged Merged a fix improving error messaging when a project file is missing. Approved by three reviewers, the change updates three files to provide clearer feedback during missing file scenarios.
70%