← Back to issue list

fix(cli): --project-dir should only be available for init and pack commands

View original Github issue

Metadata

Project
charmcraft
Number
#1565
Type
pull request
State
merged
Author
mattculler
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1565 restricted --project-dir to init and pack; the fix was cherry-picked into main by #1592 as 06c485fc.

Resolution: closed resolved

Reason: PR #1565 was approved and merged, completing the CRAFT-2434 CLI correction. PR #1592 subsequently cherry-picked it into main as commit 06c485fc.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Attempt the second. (CRAFT-2434)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1565 restricted --project-dir to init and pack; the fix was cherry-picked into main by #1592 as 06c485fc.
stealth/space-bunny-alpha — closed resolved Merged #1565 restricted --project-dir to init and pack. PR #1592 subsequently cherry-picked the fix into main as commit 06c485fc.
stealth/space-bunny-alpha — closed resolved Merged via canonical/charmcraft#1592 (06c485fc), restricting --project-dir to init and pack by cherry-picking #1565.
qwen/qwen3.6-35b-a3b — — Merged a fix restricting the --project-dir CLI flag to only init and pack commands. The change removed the global flag, cleaned up tests, and reduced code by nearly 600 lines. Approved by reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Restricts the --project-dir CLI flag to init and pack commands only. Includes test cleanup for the legacy entry point and addresses LXD disk path validation errors during packaging. Aligns with CRAFT-2434.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1592 fix(cli): restrict --project-dir to init and pack commands (#1565) charmcraft merged Merged into main as 06c485fc, cherry-picking #1565 to restrict --project-dir to init and pack commands.
92%
#1583 fix(cli): restrict --project-dir to init and pack commands (#1565) charmcraft closed Closed as superseded: #1592 merged the equivalent --project-dir restriction in commit 06c485fc.
88%
#253 fix(application): Only allow --project-dir for init and pack craft-application closed Closed unmerged after changes were requested, with two unresolved comments and no activity for 946 days; an equivalent fix later merged in charmcraft#1565 via #1592 (06c485fc).
74%
#229 fix: make project directory loading less strict. craft-application merged Merged PR #229 in commit 341e378d: project-directory loading now permits missing directories and rejects only incompatible existing paths, supporting commands such as init.
71%