← Back to issue list

feat(provider)!: get build env from command line, env, and snap config

View original Github issue

Metadata

Project
craft-application
Number
#242
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged. Extends provider configuration to fetch the build environment from CLI flags, environment variables, and snap config. Approved by two reviewers with passing CI. Includes migration notes for breaking changes.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- - Extend `get_provider()` to get the provider from the command line (`--use-lxd`), the environment (`CRAFT_BUILD_ENVIRONMENT`) or the snap config - Extend `run_managed()` to see if `CRAFT_BUILD_ENVIRONMENT=host` I decided not to add spread tests in snapcraft because they are time-consuming and hard to verify (whether LXD or Multipass was used, the artifact will be the same in the end). (CRAFT-2477)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Extends provider configuration to fetch the build environment from CLI flags, environment variables, and snap config. Approved by two reviewers with passing CI. Includes migration notes for breaking changes.
qwen3.6-35b-a3b-mtp-q6 Merged. Extends get_provider and run_managed to resolve the build environment via CLI flag, CRAFT_BUILD_ENVIRONMENT env var, or snap config. Tests added in PR 4616. Breaking change requires downstream updates to handle new environment resolution.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4616 feat: get build env from command line, env, and snap config snapcraft closed Merged via PR #4659. Enables snapcraft to determine the build environment for core24 snaps from the command line, environment variables, and snap configuration.
77%