← Back to issue list

feat(provider)!: get build env from command line, env, and snap config

View original Github issue

Metadata

Project
craft-application
Number
#242
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #242 as a4738e8a, adding provider selection from CLI flags, CRAFT_BUILD_ENVIRONMENT, and snap config, plus host-mode handling.

Resolution: closed resolved

Reason: PR #242 was approved and merged, resolving CRAFT-2477 in commit a4738e8a. The change defines build-provider precedence and makes managed builds honor host mode.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- - Extend `get_provider()` to get the provider from the command line (`--use-lxd`), the environment (`CRAFT_BUILD_ENVIRONMENT`) or the snap config - Extend `run_managed()` to see if `CRAFT_BUILD_ENVIRONMENT=host` I decided not to add spread tests in snapcraft because they are time-consuming and hard to verify (whether LXD or Multipass was used, the artifact will be the same in the end). (CRAFT-2477)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #242 as a4738e8a, adding provider selection from CLI flags, CRAFT_BUILD_ENVIRONMENT, and snap config, plus host-mode handling.
stealth/space-bunny-alpha — closed resolved Merged CRAFT-2477 in canonical/craft-application#242, selecting the build provider from CLI flags, environment variables, and snap configuration, with host handling in run_managed().
qwen/qwen3.6-35b-a3b — — Merged. Extends provider configuration to fetch the build environment from CLI flags, environment variables, and snap config. Approved by two reviewers with passing CI. Includes migration notes for breaking changes.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4616 (confidence 96%)

    Companion Snapcraft spread-test changes were cited in the merged PR comments.

Related issues

Issue Project State Summary Similarity
#4616 feat: get build env from command line, env, and snap config snapcraft closed PR closed unmerged by author mr-cal: its commits were already landed via merged PR #4659 ("fix: update to craft-application latest"), which pulled in #4616 along with #4643 and #4651.
72%