← Back to issue list

feat: get build env from command line, env, and snap config

View original Github issue

Metadata

Project
snapcraft
Number
#4616
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR closed unmerged by author mr-cal: its commits were already landed via merged PR #4659 ("fix: update to craft-application latest"), which pulled in #4616 along with #4643 and #4651.

Resolution: closed superseded

Reason: Maintainer mr-cal closed #4616 on 2024-03-13 with the comment "Closing because the commits here were merged in via #4659." PR #4659 was merged and delivered the same craft-application build-environment work, so this PR was redundant.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Now that https://github.com/canonical/craft-application/pull/242 has landed, snapcraft can determine the build environment for core24 snaps. (CRAFT-2477)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR closed unmerged by author mr-cal: its commits were already landed via merged PR #4659 ("fix: update to craft-application latest"), which pulled in #4616 along with #4643 and #4651.
stealth/space-bunny-alpha — closed resolved Build-environment detection for core24 was delivered by PR #4659, which merged #4616’s commits after the original PR was closed.
qwen/qwen3.6-35b-a3b — — Merged via PR #4659. Enables snapcraft to determine the build environment for core24 snaps from the command line, environment variables, and snap configuration.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded because its commits were merged via pull request #4659. The changes enable snapcraft to determine the build environment for core24 snaps using command line, environment variables, and snap config.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#4659 (confidence 96%)

    Merged PR the author cited as the vehicle for these commits.

  • Related To: canonical/craft-application#242 (confidence 80%)

    Upstream craft-application change that enabled build-environment determination for core24.

  • Related To: canonical/snapcraft#4643 (confidence 70%)

    Companion craft-application update PR bundled into the same #4659 merge.

  • Related To: canonical/snapcraft#4651 (confidence 70%)

    Companion craft-application update PR bundled into the same #4659 merge.

Related issues

Issue Project State Summary Similarity
#242 feat(provider)!: get build env from command line, env, and snap config craft-application merged Merged #242 as a4738e8a, adding provider selection from CLI flags, CRAFT_BUILD_ENVIRONMENT, and snap config, plus host-mode handling.
72%