fix(application): return the correct error code
Metadata
Current evaluation
Merged PR #277 (commit 235e1368) so CraftError and subclasses now return their configured error code when raised while running the application.
Resolution: closed resolved
Reason: PR #277 was approved and merged as commit 235e1368. Its change makes runtime error handling use the return code from CraftError or a subclass instead of a generic code.
Evaluated by: mr-cal-bot
No scores available.
Issue body
If a CraftError (or subclass) is raised when running the application, use its return code.
Credit for finding this bug goes to @syu-w
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #277 (commit 235e1368) so CraftError and subclasses now return their configured error code when raised while running the application. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #277 in commit 235e1368, fixing application error handling to return a CraftError or subclass's configured return code. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix ensuring the application returns the correct error code when a CraftError or subclass is raised. Approved by two reviewers, passed CI, and modified two files. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #695 fix(Application): catch all craft-like errors | craft-application | merged | Merged PR #695 in commit deca76bd, converting craft-like application errors into CraftError instances instead of internal errors and fixing #693. |