fix(application): return the correct error code
Metadata
Current evaluation
Merged fix ensuring the application returns the correct error code when a CraftError or subclass is raised. Approved by two reviewers, passed CI, and modified two files.
Suggested action: —
No scores available.
Issue body
If a CraftError (or subclass) is raised when running the application, use its return code.
Credit for finding this bug goes to @syu-w
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix ensuring the application returns the correct error code when a CraftError or subclass is raised. Approved by two reviewers, passed CI, and modified two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix ensuring the application returns the correct error code from raised CraftError instances. Resolves bug where CraftError subclasses failed to propagate their intended return codes, improving error handling reliability. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #695 fix(Application): catch all craft-like errors | craft-application | merged | Merged after resolving #693. Catches craft-like errors during execution, duck-types them, and converts them to CraftError instances instead of internal errors. Approved by two reviewers with passing CI checks. |