fix(Application): catch all craft-like errors
Metadata
Current evaluation
Merged PR #695 in commit deca76bd, converting craft-like application errors into CraftError instances instead of internal errors and fixing #693.
Resolution: closed resolved
Reason: PR #695 was merged as commit deca76bd. Its duck-typed exception handling catches all craft-like errors and resolves issue #693.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This catches all craft-like errors when running the application. Instead of converting them to internal errors, it duck-types them and converts them to CraftError instances.
Fixes #693
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #695 in commit deca76bd, converting craft-like application errors into CraftError instances instead of internal errors and fixing #693. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #695 in commit deca76bd, fixing #693 by converting all craft-like runtime errors into CraftError instances instead of internal errors. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #695 in commit deca76bd, fixing #693 by converting craft-like application errors into CraftError instances instead of internal errors. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after resolving #693. Catches craft-like errors during execution, duck-types them, and converts them to CraftError instances instead of internal errors. Approved by two reviewers with passing CI checks. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
craft-application#693
(confidence 100%)
PR #695 explicitly states that it fixes the craft-platforms errors reported in issue #693.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #479 Application: treat CraftError-like exceptions as CraftErrors | craft-application | open | CraftError-like exceptions bubbling to Application were reported as internal errors; PR #695 added a craft_platforms.CraftError branch in handle_runtime_error, so this appears resolved but the issue remains open. | |
| #277 fix(application): return the correct error code | craft-application | merged | Merged PR #277 (commit 235e1368) so CraftError and subclasses now return their configured error code when raised while running the application. |