fix(Application): catch all craft-like errors
Metadata
Current evaluation
Merged after resolving #693. Catches craft-like errors during execution, duck-types them, and converts them to CraftError instances instead of internal errors. Approved by two reviewers with passing CI checks.
Suggested action: —
No scores available.
Issue body
This catches all craft-like errors when running the application. Instead of converting them to internal errors, it duck-types them and converts them to CraftError instances.
Fixes #693
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after resolving #693. Catches craft-like errors during execution, duck-types them, and converts them to CraftError instances instead of internal errors. Approved by two reviewers with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Resolved #693 by catching craft-like errors and converting them to CraftError instances instead of internal errors. Duck-typing ensures consistent application error handling. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #277 fix(application): return the correct error code | craft-application | merged | Merged fix ensuring the application returns the correct error code when a CraftError or subclass is raised. Approved by two reviewers, passed CI, and modified two files. | |
| #479 Application: treat CraftError-like exceptions as CraftErrors | craft-application | open | Application should treat exceptions following CraftError's message/resolution pattern as CraftErrors instead of converting them to internal errors. Open since 2023, last activity 465 days ago, no labels or maintainer response beyond a Jira sync bot comment. |