← Back to issue list

commands: add basic lifecycle commands

View original Github issue

Metadata

Project
craft-application
Number
#29
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals and passing CI. Adds basic lifecycle commands across eight files, introducing 748 lines and removing 11. Maintains 100 percent test coverage.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals and passing CI. Adds basic lifecycle commands across eight files, introducing 748 lines and removing 11. Maintains 100 percent test coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into main, adding basic lifecycle commands. The contribution maintained 100% test coverage and was authored by maintainer lengau. Integration completed successfully with no additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4584 lifecycle commands snapcraft merged Merged implementation of lifecycle commands. Approved by two reviewers, passed all CI checks, and modified 15 files with full test coverage.
84%
#3902 commands: update lifecycle docstrings snapcraft merged Merged into main following approval and passing CI. Updates lifecycle docstrings to standardize command class summaries. Coverage unchanged.
74%
#148 clean cmd: migrate to use new lifecycle attribs snapcraft merged Merged after approval. The clean command now uses new lifecycle attributes and real elements instead of mocks, modifying five files with a net reduction of 69 lines.
74%
#366 Migrate lifecycle commands rockcraft merged Migrated lifecycle commands across 42 files, reducing code by 2672 lines and adding 563. Approved by three reviewers and merged after resolving 16 review comments.
74%
#64 commands: add lifecycle step commands rockcraft merged Merged. Implemented rockcraft commands for the parts lifecycle steps: pull, overlay, build, stage, and prime. Approved by one reviewer, changing seven files with 211 additions and 35 deletions. Originally created to debug OCI whiteout file issues.
73%
#1538 chore: replace most lifecycle commands with upstream ones charmcraft merged Merged. Replaced most lifecycle commands with upstream versions, removing 297 lines across two files. Approved by three reviewers. Unit tests were not removed since only the pack command had substantial tests, which still requires upstream extension.
73%
#2163 tests: add lifecycle ordering tests snapcraft merged Merged changes adding lifecycle ordering tests and refactoring them into a dedicated package. Approved by a reviewer, passed CI checks, and increased code coverage by 0.02%.
71%
#4431 feat: improve lifecycle messages snapcraft merged Merged into main following approval from two reviewers and passing CI checks. The change improves lifecycle messages across six files (+61/-54 lines) with 87.50% diff coverage.
70%