clean cmd: migrate to use new lifecycle attribs
Metadata
Current evaluation
Merged PR #148 by sergiusens: migrated the clean command to the new lifecycle attributes, dropping mocks in favour of real elements (+87/-156, 5 files). Merged as commit 71e1db7bd.
Resolution: closed resolved
Reason: The pull request was merged into the project after review by come-maiz, who approved the mock-free implementation on 2015-12-03. The change landed as commit 71e1db7bd ('clean cmd: migrate to use new lifecycle attribs'), and the resulting behaviour is still visible today in snapcraft/commands/lifecycle.py where CleanCommand subclasses craft_application.commands.lifecycle.CleanCommand.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This also migrates clean to use real elements instead of
over mocking.
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #148 by sergiusens: migrated the clean command to the new lifecycle attributes, dropping mocks in favour of real elements (+87/-156, 5 files). Merged as commit 71e1db7bd. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#148: clean now uses the new lifecycle attributes and real elements instead of mocks. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval. The clean command now uses new lifecycle attributes and real elements instead of mocks, modifying five files with a net reduction of 69 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes migrating the clean command to use new lifecycle attributes and real elements instead of mocks. Reviewer approved the updates, and the code was integrated into the main branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3630 cli: add lifecycle command stubs (CRAFT-764) | snapcraft | merged | Merged PR #3630 as commit 2759ad4af, adding pull, build, stage, and prime command stubs with legacy fallbacks and reorganizing CLI tests. | |
| #29 commands: add basic lifecycle commands | craft-application | merged | Merged PR #29 added basic lifecycle commands in commit 3e47b0dd, changing eight files with 100% diff coverage. | |
| #5332 docs: migrate 'parts lifecycle' | snapcraft | merged | Merged the parts lifecycle documentation migration in PR #5332, updating five files (+272/-27); landed as commit fc43c788d. |