← Back to issue list

clean cmd: migrate to use new lifecycle attribs

View original Github issue

Metadata

Project
snapcraft
Number
#148
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after approval. The clean command now uses new lifecycle attributes and real elements instead of mocks, modifying five files with a net reduction of 69 lines.

Suggested action:

No scores available.

Issue body

This also migrates clean to use real elements instead of over mocking. Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval. The clean command now uses new lifecycle attributes and real elements instead of mocks, modifying five files with a net reduction of 69 lines.
qwen3.6-35b-a3b-mtp-q6 Merged changes migrating the clean command to use new lifecycle attributes and real elements instead of mocks. Reviewer approved the updates, and the code was integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 Merged. The clean command now uses new lifecycle attributes and real elements instead of mocks. Approved by @come-maiz and merged by maintainer @sergiusens.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#29 commands: add basic lifecycle commands craft-application merged Merged after two approvals and passing CI. Adds basic lifecycle commands across eight files, introducing 748 lines and removing 11. Maintains 100 percent test coverage.
74%
#366 Migrate lifecycle commands rockcraft merged Migrated lifecycle commands across 42 files, reducing code by 2672 lines and adding 563. Approved by three reviewers and merged after resolving 16 review comments.
73%
#4584 lifecycle commands snapcraft merged Merged implementation of lifecycle commands. Approved by two reviewers, passed all CI checks, and modified 15 files with full test coverage.
70%