← Back to issue list

feat(grammar): enable grammar-aware for all PartSpec

View original Github issue

Metadata

Project
craft-application
Number
#296
Type
pull request
State
merged
Author
syu-w
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/craft-application#296 (commit 14ff3d35) by maintainer syu-w, enabling grammar-aware `- on X to Y: values` syntax for all PartSpec entries, built on the prerequisite craft-grammar#17 grammar types.

Resolution: closed resolved

Reason: The pull request was approved by 3 reviewers and merged to main as commit 14ff3d35, landing the grammar-aware PartSpec feature (+531/-38 across 5 files) that depended on the merged prerequisite canonical/craft-grammar#17.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This allows use `- on X to Y: values` in all parts. Needs: https://github.com/canonical/craft-grammar/pull/17

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/craft-application#296 (commit 14ff3d35) by maintainer syu-w, enabling grammar-aware `- on X to Y: values` syntax for all PartSpec entries, built on the prerequisite craft-grammar#17 grammar types.
stealth/space-bunny-alpha — closed resolved Merged in craft-application#296 (14ff3d35), enabling grammar-aware "- on X to Y: values" syntax for all PartSpec entries.
qwen/qwen3.6-35b-a3b — — Merged to enable grammar-aware syntax for all PartSpec. Approved by three reviewers, the update adds - on X to Y: values support across five files (+531/-38 lines) and depends on craft-grammar PR #17.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-grammar#17 (confidence 95%)

    Explicit prerequisite cited in the PR body; merged PR adding bool/int/float/dict/list grammar types.

  • Related To: canonical/craft-application#328 (confidence 55%)

    Follow-up fix (commit 2a1115d0) allowing mixed strings/dicts in grammar lists, shipped in 2.6.2.

  • Related To: canonical/craft-application#330 (confidence 55%)

    Follow-up fix (commit 6a302635) skipping grammar processing for non-grammar keys.

Related issues

No related issues found above the similarity threshold.