fix: allow a mix of strings and dicts for grammar
Metadata
Current evaluation
Merged craft-application#328 as commit 2a1115d0, allowing grammar lists to mix strings and dicts; released in 2.6.2 and regression-tested by snapcraft#4768.
Resolution: closed resolved
Reason: PR #328 was merged as commit 2a1115d0, enabling grammar lists containing both strings and dictionaries. The fix shipped in craft-application 2.6.2, resolved snapcraft#4764, and was covered downstream by snapcraft#4768.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Fixes https://github.com/canonical/snapcraft/issues/4764
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-application#328 as commit 2a1115d0, allowing grammar lists to mix strings and dicts; released in 2.6.2 and regression-tested by snapcraft#4768. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4768 (c76e6267), adding regression coverage for mixed grammar and standard list entries. craft-application 2.6.2 supplied the parser fix, resolving #4764. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix allowing mixed strings and dicts in grammar parsing, resolving issue #4764. Approved by two reviewers, the change updates three files with 33 additions and 4 deletions. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#4764
(confidence 100%)
The Snapcraft regression explicitly identified as fixed by craft-application#328.
-
Likely Fixed By:
canonical/snapcraft#4768
(confidence 98%)
Merged downstream fix c76e62671 added regression coverage for mixed grammar and standard list entries.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4764 Regression: Advanced grammar cannot be combined with other data | snapcraft | closed | Fixed by merged snapcraft#4768 (c76e62671), adding regression coverage for mixed grammar and standard list entries; parsing was fixed in craft-application 2.6.2. | |
| #4716 test(grammar): new grammar support | snapcraft | closed | PR #4716 (unit tests for new grammar support) was approved but closed unmerged; maintainer @mr-cal closed it because craft-application#296 was merged/released and equivalent Snapcraft tests landed in merged #4768 (c76e626). | |
| #1684 Vendor grammar logic into snapcraft | snapcraft | closed | Advanced grammar was extracted to craft-grammar and adopted by Snapcraft in #3642 (merge 943d130c2), superseding the planned in-tree refactor. | |
| #3654 projects: add grammar validation | snapcraft | merged | Merged #3654 via commit 17fcb85f8, validating snapcraft.yaml with craft-grammar Pydantic models before processing grammar-aware properties. |