← Back to issue list

Support local key assets for package-repositories

View original Github issue

Metadata

Project
craft-application
Number
#313
Type
issue
State
open
Author
tigarmo
Labels
—
Created
Updated
Closed
—

Current evaluation

Feature request to support local key assets (e.g. snap/keys) in package-repositories instead of hardcoding /dev/null. Resolved by merged PR #317 (071ad272), which added a local_keys_path parameter and an overridable _get_local_keys_path() hook.

Suggested action: close resolved

Reason: The code confirms the fix landed: craft_application/util/repositories.py now computes `key_assets = local_keys_path if local_keys_path else Path("/dev/null")` and LifecycleService._get_local_keys_path() is an overridable hook called from run(), with unit tests in tests/unit/services/test_repositories.py and test_lifecycle.py covering both the None and provided-path cases. git_log_path on that file shows commit 071ad272 "feat: support local keys in package-repositories (#317)", and the downstream consumer snapcraft#4743 was closed via snapcraft PR #4758. The only remaining comment is an autogenerated Jira sync bot message, not substantive discussion.

Evaluated by: mr-cal-bot

Impact: 55 Quick Win: 30 Complexity: 35 Confidence: 95 Actionability: 85

Issue body

### What needs to get done The current implementation of package-repositories does not support local key assets (the local dir is always /dev/null). ### Why it needs to get done Snapcraft has support for keys in `snap/keys`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 55
Quick Win: 30
Complexity: 35
Confidence: 95
Actionability: 85
close resolved Feature request to support local key assets (e.g. snap/keys) in package-repositories instead of hardcoding /dev/null. Resolved by merged PR #317 (071ad272), which added a local_keys_path parameter and an overridable _get_local_keys_path() hook.
qwen/qwen3.6-35b-a3b
Impact: 70
Quick Win: 39
Complexity: 30
Confidence: 95
Actionability: 80
close resolved Feature request to support local key assets for package-repositories. Implemented and merged in PR #317.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 32
Staleness: 70
Complexity: 30
Confidence: 85
Support Request: 0
close stale Feature request to support local key assets for package-repositories (local dir was always /dev/null). Implemented by merged PR #317 adding an overridable _get_local_keys_path hook; issue is inactive and can be closed.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 40
Confidence: 75
Support Request: 10
needs triage Issue requesting support for local key assets in package-repositories, as current implementation ignores local keys. Created over 2 years ago, last activity 1 year ago, with an autogenerated Jira ticket link. Awaiting triage/development.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 40
Confidence: 70
Support Request: 10
needs triage Feature request to support local key assets for package-repositories. Unlabelled, unassigned, and inactive for over a year with no maintainer response.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: craft-application#317 (confidence 98%)

    Merged PR 'feat: support local keys in package-repositories' (commit 071ad272) implemented exactly what this issue requests; appears in the history of craft_application/util/repositories.py.

  • Related To: snapcraft#4743 (confidence 90%)

    Downstream Snapcraft bug 'Local key assets are not used in package-repositories for core24' — the motivating consumer; closed via snapcraft PR #4758.

Related issues

Issue Project State Summary Similarity
#317 feat: support local keys in package-repositories craft-application merged Merged PR #317 (commit 071ad272), adding local-key support for package repositories through an overridable assets hook for applications such as Snapcraft.
85%
#4743 Local key assets are not used in package-repositories for core24 snapcraft closed Fixed in merged PR #4758 (commit b8ff64b89), enabling core24 package repositories to use local signing keys instead of only a keyserver.
73%