← Back to issue list

feat: support local keys in package-repositories

View original Github issue

Metadata

Project
craft-application
Number
#317
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged PR implementing local key support for package repositories. Introduces an overridable method for applications providing local assets, such as Snapcraft. Approved by two reviewers, passed CI, and applied across five files (+54/-12 lines).

Suggested action:

No scores available.

Issue body

This isn't supported by default in the base Application class itself because there is no universal "assets" location that satisfies all applications, but provides a method that applications that _do_ provide local assets (Snapcraft) can override. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged PR implementing local key support for package repositories. Introduces an overridable method for applications providing local assets, such as Snapcraft. Approved by two reviewers, passed CI, and applied across five files (+54/-12 lines).
qwen3.6-35b-a3b-mtp-q6 Merged feature adding local key support for package-repositories. Introduces an overridable method in the base Application class, enabling applications like Snapcraft to handle local assets without a universal assets directory.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#313 Support local key assets for package-repositories craft-application open Feature request to support local key assets for package-repositories (local dir was always /dev/null). Implemented by merged PR #317 adding an overridable _get_local_keys_path hook; issue is inactive and can be closed.
78%
#178 feat: support package-repositories in project craft-application merged Merged a feature enabling applications to install additional package repositories in the build system. Approved by two reviewers, passed CI and coverage checks, and validated in Rockcraft with expected results.
72%
#217 repo: add support for package repositories rockcraft merged Added support for package repositories. Merged after approval by two reviewers and passing CI checks. Modified 16 files (+346/-31), resolving CRAFT-1553 and enabling downstream testing.
72%
#4758 fix: use local keys for package-repos in core24 snapcraft merged Merged following two approvals and passing CI. Updates package repository configuration to use local keys for core24 across three files (+47 lines). All modified code is covered by tests.
71%