← Back to issue list

feat: support local keys in package-repositories

View original Github issue

Metadata

Project
craft-application
Number
#317
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #317 (commit 071ad272), adding local-key support for package repositories through an overridable assets hook for applications such as Snapcraft.

Resolution: closed resolved

Reason: The approved PR was merged as commit 071ad272. It passes an application-provided local-assets path to package-repository key handling while allowing applications without local assets to retain existing behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This isn't supported by default in the base Application class itself because there is no universal "assets" location that satisfies all applications, but provides a method that applications that _do_ provide local assets (Snapcraft) can override. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #317 (commit 071ad272), adding local-key support for package repositories through an overridable assets hook for applications such as Snapcraft.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-application#317 (071ad272), adding local-key support through an overridable assets hook, enabling applications such as Snapcraft to provide local key files.
qwen/qwen3.6-35b-a3b — — Merged PR implementing local key support for package repositories. Introduces an overridable method for applications providing local assets, such as Snapcraft. Approved by two reviewers, passed CI, and applied across five files (+54/-12 lines).

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#313 Support local key assets for package-repositories craft-application open Feature request to support local key assets (e.g. snap/keys) in package-repositories instead of hardcoding /dev/null. Resolved by merged PR #317 (071ad272), which added a local_keys_path parameter and an overridable _get_local_keys_path() hook.
85%