feat: add a method to enable craft-parts Features
Metadata
Current evaluation
Merged a method for Application subclasses to enable craft-parts features at the correct initialization point, ensuring proper setup order for overlays and logging. Approved, passed CI, and changed 30 lines across two files.
Suggested action: —
No scores available.
Issue body
The correct location to add craft-parts Features is a bit tricky:
- it must happen soon enough that things that happen early have the correct features enabled. For example, building the default command groups takes into account whether overlays are enabled;
- it must happen late enough that the craft-cli logging support has already been set-up.
Therefore, provide a method that Application subclasses can override to enable their features, and the Application itself takes care of calling it at the correct time.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a method for Application subclasses to enable craft-parts features at the correct initialization point, ensuring proper setup order for overlays and logging. Approved, passed CI, and changed 30 lines across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a lifecycle hook allowing Application subclasses to enable craft-parts features at the correct initialization point, ensuring logging is configured before command group processing. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #367 features: introduce craft-parts features | craft-parts | merged | Successfully merged, introducing configurable features for craft-parts including an optional overlay feature to control action generation. Approved by reviewer, passed CI, and integrated after build retrigger. | |
| #336 features: introduce craft-parts features | craft-parts | merged | Merged pull request introducing a configurable feature system to craft-parts, including an initial overlay feature implementation. Approved by reviewer, passed CI, and merged with 620 additions and 12 deletions across 14 files. | |
| #602 fix: enable overlays in _enable_craft_parts_features() | rockcraft | merged | Merged a fix enabling overlays in _enable_craft_parts_features(). Approved by two reviewers with passing CI checks. A minor testing note was dismissed when the reviewer used the correct environment. The change was successfully integrated. | |
| #299 feat: enable override-overlay | imagecraft | merged | Merged following approval from two reviewers and passing CI checks. Updated craft-parts to ~2.30 to enable override-overlay support and added a corresponding spread test. | |
| #3636 parts: integrate craft-parts (CRAFT-765) | snapcraft | merged | Merged after reviewer approval and passing CI checks. Integrates craft-parts for part validation and lifecycle processing. Modifies 12 files, adding 369 lines and removing 20, fulfilling CRAFT-765. | |
| #334 features: introduce craft-parts features | craft-parts | closed | Abandoned after 1315 days with no reviews or CI checks. The change introduced a configurable features system for craft-parts, including a minimal overlay implementation, but was closed without merging. | |
| #4083 requirements: update craft-parts to 1.19.0 | snapcraft | merged | Merged update to craft-parts 1.19.0, enabling optional overlay steps, feature selection, and improved dirty checking. Approved by reviewer, passed CI, and merged into main. | |
| #1330 feat(craft-app): Add craft-application services | charmcraft | merged | Merged feat(craft-app): Add craft-application services. Approved by two reviewers, the change modified 56 files with 2143 additions and 230 deletions. The author fixed changelist misalignments causing spread test failures before merge. | |
| #110 feat: Support overlay | imagecraft | merged | Merged to enable the overlay feature, provide a bare base, and add spread tests. Approved by two reviewers with passing CI checks. Resolves #98 and CRAFT-4269 across 18 files. | |
| #19 parts: add craftctl support | rockcraft | merged | Merged after reviewer approval. Updated craft-parts to 1.4.1 and enabled craftctl support in step overrides across 16 files. Changes totaled +145/-66 lines. All CI checks passed with no unresolved comments. |