feat: add a method to enable craft-parts Features
Metadata
Current evaluation
Merged craft-application#362 in commit 9ba1d2a8, adding an Application hook to enable craft-parts features after logging setup and before plugin setup.
Resolution: closed resolved
Reason: PR #362 was approved and merged as commit 9ba1d2a8. It invokes the new overridable Application hook at startup so subclasses can configure craft-parts before plugins and default command groups are initialized.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The correct location to add craft-parts Features is a bit tricky:
- it must happen soon enough that things that happen early have the correct features enabled. For example, building the default command groups takes into account whether overlays are enabled;
- it must happen late enough that the craft-cli logging support has already been set-up.
Therefore, provide a method that Application subclasses can override to enable their features, and the Application itself takes care of calling it at the correct time.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-application#362 in commit 9ba1d2a8, adding an Application hook to enable craft-parts features after logging setup and before plugin setup. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #362 in commit 9ba1d2a8, adding an Application hook to enable craft-parts features after logging setup and before plugin and command setup. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #362 in commit 9ba1d2a8, adding an overridable Application hook to enable craft-parts features after logging setup and before plugin/command initialization. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-application#362 in commit 9ba1d2a8, adding an Application hook to enable craft-parts features after logging setup and before plugin/command setup. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a method for Application subclasses to enable craft-parts features at the correct initialization point, ensuring proper setup order for overlays and logging. Approved, passed CI, and changed 30 lines across two files. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #628 feat: application plugins | craft-application | merged | Merged as commit 4689bb1a, enabling applications to register plugins that modify library behavior for CRAFT-4018. | |
| #336 features: introduce craft-parts features | craft-parts | merged | Feature controls landed via canonical/craft-parts#367 in commit 16a81f95, adding configurable features and suppression of overlay actions when the overlay feature is disabled. | |
| #1608 feat: allow applications to set build environment | craft-parts | merged | Merged in craft-parts#1608 via commit 0f7a4b1c, adding an application-level build environment whose defaults can be overridden by each part. | |
| #334 features: introduce craft-parts features | craft-parts | closed | Closed unmerged and superseded by canonical/craft-parts#367, which merged the same feature work in commit 16a81f95, adding configurable features and an overlay toggle. |