← Back to issue list

features: introduce craft-parts features

View original Github issue

Metadata

Project
craft-parts
Number
#336
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Feature controls landed via canonical/craft-parts#367 in commit 16a81f95, adding configurable features and suppression of overlay actions when the overlay feature is disabled.

Resolution: closed resolved

Reason: PR #336 was integrated by merged PR #367 as commit 16a81f95. The change introduced feature configuration and an overlay toggle that prevents overlay-action generation when disabled.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Craft-parts can now specify features that can be enabled or disabled to change its behavior in certain scenarios. This change also includes a minimally intrusive implementation of the overlay feature, which inhibits the generation of overlay actions when this feature is disabled by the application. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-1531

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Feature controls landed via canonical/craft-parts#367 in commit 16a81f95, adding configurable features and suppression of overlay actions when the overlay feature is disabled.
stealth/space-bunny-alpha — closed resolved Merged in #367 via commit 16a81f95, adding configurable craft-parts features and an overlay feature that suppresses overlay actions when disabled.
qwen/qwen3.6-35b-a3b — — Merged pull request introducing a configurable feature system to craft-parts, including an initial overlay feature implementation. Approved by reviewer, passed CI, and merged with 620 additions and 12 deletions across 14 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Introduces a feature flag system to craft-parts, including a disabled-by-default overlay feature that suppresses overlay action generation when disabled. Resolves CRAFT-1531.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#367 (confidence 100%)

    Merged PR carrying the feature implementation in commit 16a81f95.

Related issues

Issue Project State Summary Similarity
#367 features: introduce craft-parts features craft-parts merged Merged PR #367 via commit 16a81f95, introducing configurable craft-parts features and an overlay toggle that suppresses overlay action generation when disabled.
91%
#334 features: introduce craft-parts features craft-parts closed Closed unmerged and superseded by canonical/craft-parts#367, which merged the same feature work in commit 16a81f95, adding configurable features and an overlay toggle.
88%
#602 fix: enable overlays in _enable_craft_parts_features() rockcraft merged Merged #602 (commit 86153dcc), enabling Craft Parts overlays during Rockcraft initialization via Features(enable_overlay=True).
74%
#299 feat: enable override-overlay imagecraft merged Merged in #299 via commit 6d283be, upgrading craft-parts to ~=2.30 and adding spread coverage for override-overlay support.
73%
#362 feat: add a method to enable craft-parts Features craft-application merged Merged craft-application#362 in commit 9ba1d2a8, adding an Application hook to enable craft-parts features after logging setup and before plugin setup.
72%
#98 Enable overlay feature imagecraft closed Overlay support was implemented in imagecraft PR #110 (commit 00f1348), after craft-parts PR #1035 (b575539e) removed the partition/overlay blocker.
70%