← Back to issue list

feat: accept build-for: [all] in platforms

View original Github issue

Metadata

Project
craft-application
Number
#365
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/craft-application#365 (CRAFT-3016): accepts 'build-for: [all]' in platform definitions, disallowing other platforms when set; closes craft-application#360, related to snapcraft#4854.

Resolution: closed resolved

Reason: The PR was merged after review approval (2 reviewers, +508/-4 across 14 files) and explicitly declares 'Fixes #360' (CRAFT-3016). craft-application issue #360 ('Allow build-for "all" for platform-independent builds') is closed and its resolution summary cites this same PR #365, confirming it as the resolver.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Allows `build-for: [all]` in a platform definition. When this is defined, no other platforms may be defined. Related to https://github.com/canonical/snapcraft/issues/4854 Fixes #360 (CRAFT-3016)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/craft-application#365 (CRAFT-3016): accepts 'build-for: [all]' in platform definitions, disallowing other platforms when set; closes craft-application#360, related to snapcraft#4854.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-application#365 to accept build-for: [all] in platform definitions, forbidding other platforms; resolves #360 (CRAFT-3016).
qwen/qwen3.6-35b-a3b — — Merged via rebase after approval and passing CI. Enables build-for: [all] in platform definitions, restricting other platforms when used. Resolves #360.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-application#360 (confidence 96%)

    Issue #360 is the parent feature request that this PR closes; its closure summary names PR #365 as the fix.

  • Related To: canonical/snapcraft#4854 (confidence 90%)

    Cited in the PR body as the related downstream snapcraft feature (build-for: [all] / --build-for=all), which was later confirmed supported.

  • Related To: canonical/craft-application#360 (confidence 88%)

    Related downstream request to accept build-for 'all' for platform-independent builds, resolving via this PR.

Related issues

Issue Project State Summary Similarity
#360 Allow build-for "all" for platform-independent builds. craft-application closed Merged PR #365 to support build-for [all] for platform-independent builds, including validation, an application-level opt-out, and tests; resolved #360 and CRAFT-3016.
79%
#254 Implement --build-for in addition to --platform craft-application closed Implemented --build-for platform selection in merged PR canonical/craft-application#272 (commit e99ee656).
75%
#598 feat: allow for multi-base builds craft-application merged Merged as d81c39a7; allowed bases in platform entries so applications can implement multi-base build plans, fixing #569 (CRAFT-3719).
73%
#483 feat: support "--platform" for "clean" craft-application merged Merged PR #483 via commit 07e89deb, adding --platform to clean so one managed instance can be removed, and fixing craft-application#425.
73%
#5111 feat: use `craft-platforms` for build plans snapcraft merged Merged in #5111 via commit 7969ee8d5, replacing Snapcraft’s custom build-plan logic with craft-platforms utilities.
72%
#4873 feat: support "build-for: [all]" in core24 snapcraft merged Merged PR #4873 as commit 319056d7a, adding core24 support for build-for: [all] and fixing #4854. The feature shipped in Snapcraft 8.4.0.
72%
#4630 feat: add platforms and drop architectures for core24 snapcraft merged Merged as canonical/snapcraft#4630 (f771a4ab8), adding optional core24 platform selection and removing legacy architectures, with host build defaults.
71%
#633 fix: improve `platforms.<platform>.build-on` validation rockcraft closed Closed unmerged as redundant: PR canonical/rockcraft#567 had already improved build-on validation by adopting craft-application's default BuildPlanner.
71%
#343 feat: allow commands to accept multiple platforms craft-application merged PR #343 was merged as e898740e, allowing commands to accept comma-separated platforms or build-fors and using the first value to configure the project.
71%