← Back to issue list

feat: accept build-for: [all] in platforms

View original Github issue

Metadata

Project
craft-application
Number
#365
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged via rebase after approval and passing CI. Enables build-for: [all] in platform definitions, restricting other platforms when used. Resolves #360.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Allows `build-for: [all]` in a platform definition. When this is defined, no other platforms may be defined. Related to https://github.com/canonical/snapcraft/issues/4854 Fixes #360 (CRAFT-3016)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged via rebase after approval and passing CI. Enables build-for: [all] in platform definitions, restricting other platforms when used. Resolves #360.
qwen3.6-35b-a3b-mtp-q6 Merged via rebase. Implements support for build-for: [all] in platform definitions, restricting configuration to a single platform. Resolves issue #360 and addresses CRAFT-3016.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5687 feat(remote): allow using shorthand platforms with --build-for snapcraft merged Merged a feature enabling shorthand platforms with the --build-for flag. The change removes a prior restriction now that related Launchpad bugs are resolved. Approved by three reviewers and passed CI checks before integration.
78%
#598 feat: allow for multi-base builds craft-application merged Merged to enable multi-base builds by allowing bases in the platforms entry. Approved by three reviewers, passed CI, and resolves issue #569. Modified four files with 46 additions and 28 deletions.
78%
#272 feat(platforms): support --build-for to select platform craft-application merged Merged to add --build-for flag for platform selection and update _filter_plan API with host_arch parameter for remote builds. Approved by two reviewers, passed CI, and resolves issue #254.
76%
#601 feat: use platform name in build instance name craft-application merged Merged. Changes build instance naming to use platform names instead of architectures, preventing shared environments. Approved by two reviewers, the +40/-10 line update across four files fixes #600 and unblocks dependent work.
74%
#343 feat: allow commands to accept multiple platforms craft-application merged Successfully merged following approval from two reviewers and passing CI checks. The feature enables commands to accept multiple platforms, updating two files with 42 additions and one deletion.
73%
#5351 fix(remote): error early for invalid platform usage snapcraft merged Merged a fix that raises an early error when --build-for conflicts with shorthand platform entries, preventing unfriendly Launchpad failures. The change passed CI checks and received approvals, resolving issue #5270.
73%
#687 fix(commands/lifecycle): Pass the correct platform and build-for craft-application merged Merged fix correcting platform and build-for parameter passing in lifecycle commands, resolving a "Multiple builds match the current platform" error. Approved by two reviewers and passed CI.
73%
#5216 feat(remotebuild)!: filter build-plan with --build-for, drop --platform snapcraft merged Merged after review and passing CI. Introduces --build-for to filter build plans, removes --platform due to Launchpad API limitations, and improves error handling. Resolves #4992.
72%
#86 feat(project): add support to platforms in build plan craft-application merged Implemented generic platform name filtering for build plans, resolving issue #83. Merged after reviewer approval and passing CI checks with 100% diff coverage.
72%
#483 feat: support "--platform" for "clean" craft-application merged Added --platform flag to the clean command for targeted instance cleanup. Merged after three approvals and passing CI, resolving issue #425. Changes modify three files with 52 additions.
72%