← Back to issue list

feat: use `craft-platforms` for build plans

View original Github issue

Metadata

Project
snapcraft
Number
#5111
Type
pull request
State
merged
Author
mattculler
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #5111 via commit 7969ee8d5, replacing Snapcraft’s custom build-plan logic with craft-platforms utilities.

Resolution: closed resolved

Reason: PR #5111 was merged into Snapcraft as commit 7969ee8d5. Repository history confirms the commit applied the build-plan refactor across six files.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #5111 via commit 7969ee8d5, replacing Snapcraft’s custom build-plan logic with craft-platforms utilities.
stealth/space-bunny-alpha — closed resolved Merged PR #5111 replaced existing build-plan logic with craft-platforms, updating six files and reducing the implementation by 17 net lines.
qwen/qwen3.6-35b-a3b — — Merged the change to replace existing build plan logic with the craft-platforms library. Approved by two reviewers, the update modifies six files with a net reduction of 17 lines, streamlining platform detection and build configuration.
qwen3.6-35b-a3b-mtp-q6 — — Merged to integrate the craft-platforms library for build plans. The change replaces legacy platform detection logic, standardizing build configurations. Approved and closed by maintainer mattculler.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5015 Use craft-platforms for build plans snapcraft closed Snapcraft adopted craft-platforms build plans in merged PR #5111 (commit 7969ee8d5), replacing its custom planning logic.
89%
#21 feat: make build plans for snaps with platforms craft-platforms merged Merged PR #21 in commit 5278aa0, adding platforms-based Snap build-plan generation and fixing #5.
81%
#698 Use craft-platforms for build plans rockcraft closed Merged PR #715 (516d29e5) replaced Rockcraft's custom build-plan generation with craft-platforms, resolving #698 and aligning plans with downstream consumers.
80%
#1894 refactor: use craft-platforms for build plans charmcraft merged Merged PR #1894 (commit f1755e8f, +25/-33) replaced Charmcraft's custom build-plan generation for `platforms` charms with craft-platforms, routing exhaustive build plans through craft-application's BuildPlanService.
77%
#391 Use craft-platforms for build plans craft-application closed Build planning and filtering moved to craft-platforms in merged PR #25 (d9ff004); craft-application adopted the planner through merged PR #666 (621d1a32).
77%
#1876 Use craft-platforms for build plans charmcraft closed Closed as done: charmcraft PR #1894 (commit f1755e8f) switched build plan generation to craft-platforms via craft-application's BuildPlanService; rockcraft did the same in #715.
75%
#362 feat: support platforms for the build plans rockcraft merged Merged PR #362, adding platform support to build plans; the change is recorded in commit 9cc5af95.
74%
#501 feat: use craft-platforms build planning craft-application closed Closed unmerged after team discussion; the redesign was later delivered separately by #666 using craft-platforms, followed by #667 removing BuildPlanner.
74%
#4 feat: add charmcraft build plans craft-platforms merged Merged charmcraft build-plan support and supporting build-plan utilities in canonical/craft-platforms#4 via commit efa325b.
74%
#83 Support "platforms" for the build plans craft-application closed Platform support for build plans was merged in craft-application#86 (commit e494797a), adding platform-name selection/filtering and closing #83.
73%