Support `--shell` and `--shell-after` for the `pack` command
Metadata
Current evaluation
Added --shell and --shell-after support to pack via merged PR #436 (commit ab55ec81); #419 was closed as a duplicate of #430, which the PR also fixed.
Resolution: closed resolved
Reason: The maintainer confirmed the change was fixed by merged PR #436 in commit ab55ec81. The PR added pack shell options and resolved duplicate issue #430.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### What needs to get done
Add support for `--shell` and `--shell-after` for the `pack` command
* Drop this override: https://github.com/canonical/craft-application/blob/a00bf9b64ab8255644b40d4013d3e75b02419872/craft_application/commands/lifecycle.py#L389
* Wrap the pack steps with the shell and shell-after functions (similar to https://github.com/canonical/craft-application/issues/415)
### Why it needs to get done
To allow developers to debug packing an artefact, such as https://github.com/canonical/snapcraft/issues/4963
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Added --shell and --shell-after support to pack via merged PR #436 (commit ab55ec81); #419 was closed as a duplicate of #430, which the PR also fixed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #436 (ab55ec81), adding --shell and --shell-after to pack; the issue was also tracked by #430 and linked to #415. | |
| qwen/qwen3.6-35b-a3b | — | — | Added support for --shell and --shell-after to the pack command. Fixed via pull request #436 and marked as a duplicate of issue #430. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed via pull request #436. Added --shell and --shell-after support to the pack command by wrapping pack steps with shell functions and removing a previous override. Marked as a duplicate of issue #430. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-application#436
(confidence 100%)
Merged PR #436, commit ab55ec81, added shell and shell-after support to pack.
-
Duplicate Of:
canonical/craft-application#430
(confidence 100%)
The maintainer explicitly marked #419 as a duplicate; PR #436 also fixed #430.
-
Related To:
canonical/craft-application#415
(confidence 95%)
The requested pack behavior was modeled on related shell and failure-debugging work in #415.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #430 Properly support `--shell`, `--shell-after` and `--debug` on `pack` | craft-application | closed | Fixed by merged PR #436 (ab55ec81), adding --shell and --shell-after to pack and applying --debug when packing fails. | |
| #4963 Support `--shell` and `--shell-after` for `snapcraft pack` | snapcraft | closed | Restored --shell and --shell-after for snapcraft pack via merged craft-application#436 (ab55ec81); the fix shipped in Snapcraft 8.4.1. | |
| #436 feat: support shell/shell-after and debug in 'pack' | craft-application | merged | Merged craft-application#436 (commit ab55ec81), adding --shell/--shell-after to pack and making --debug shell into the build environment when packing fails; fixes #430. | |
| #650 The `--shell` action for `pack` is broken | charmcraft | closed | Reporter facundobatista found `pack --shell` broken after output moved to the Emitter; fixed by PR #740 (branch pause-emitter-when-asking-for-input, merge commit e70ed86f), merged2022-04-28. | |
| #495 pack: add support for --debug, --shell, and --shell-after (CRAFT-408) | charmcraft | merged | Merged in commit 1a957995, adding --debug, --shell, and --shell-after to pack for interactive and failure-triggered build debugging. | |
| #58 Implement "--shell", "--shell-after" and "--debug" | craft-application | closed | Implemented --shell, --shell-after and --debug support through merged PR #436 (commit ab55ec81). |