feat: support shell/shell-after and debug in 'pack'
Metadata
Current evaluation
Merged craft-application#436 (commit ab55ec81), adding --shell/--shell-after to pack and making --debug shell into the build environment when packing fails; fixes #430.
Resolution: closed resolved
Reason: The pull request was merged as commit ab55ec81. Its description states that it fixes issue #430 and documents pack-time shell access plus debugging of packing failures.
Evaluated by: mr-cal-bot
No scores available.
Issue body
`--shell` and `--shell-after` are implemented for a) consistency with the other lifecycle commands, and b) because it makes sense to want to inspect the build environment at packing time, considering that there are packing-related steps, like writing the metadata file, that the users don't have a way to inspect otherwise (short of examining the final artefact).
`--debug` is improved to actually shell into the build environment when the packing itself failed, as opposed to the previous behavior of only debugging failures that happen during the lifecycle steps.
Fixes #430
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-application#436 (commit ab55ec81), adding --shell/--shell-after to pack and making --debug shell into the build environment when packing fails; fixes #430. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #436 (commit ab55ec81), adding --shell/--shell-after to pack and making --debug enter the build environment on packing failures; fixes #430. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-application#436 (commit ab55ec81), adding --shell and --shell-after to pack and enabling --debug for packing failures, resolving #430. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following two approvals and passing CI. Introduces --shell and --shell-after flags to the pack command for build environment inspection, and improves --debug to activate on packing failures. Resolves #430. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-application#430
(confidence 100%)
PR #436 explicitly states that it fixes #430.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #495 pack: add support for --debug, --shell, and --shell-after (CRAFT-408) | charmcraft | merged | Merged in commit 1a957995, adding --debug, --shell, and --shell-after to pack for interactive and failure-triggered build debugging. | |
| #430 Properly support `--shell`, `--shell-after` and `--debug` on `pack` | craft-application | closed | Fixed by merged PR #436 (ab55ec81), adding --shell and --shell-after to pack and applying --debug when packing fails. | |
| #81 feat: implement --shell, shell-after, --debug | craft-application | merged | Merged PR #81 as commit acad93da, adding --shell, --shell-after and --debug support and resolving #58 after approval by two maintainers. | |
| #419 Support `--shell` and `--shell-after` for the `pack` command | craft-application | closed | Added --shell and --shell-after support to pack via merged PR #436 (commit ab55ec81); #419 was closed as a duplicate of #430, which the PR also fixed. | |
| #3895 parts: allow debug shell after the lifecycle | snapcraft | merged | Merged #3895 (725d3935) into hotfix/7.1.4, allowing --debug to open a build-environment shell when packing fails after the parts lifecycle. | |
| #415 `--debug` does not enter a shell for failures during post-prime or packing | craft-application | closed | Fixed by merged PR #436 (commit ab55ec81), adding --shell/--shell-after to pack and making --debug drop into a shell when packing fails; closed by maintainer tigarmo on 2024-09-10. | |
| #772 packing with `--debug` showing building message over shell | charmcraft | closed | Reported --debug shell showing the BUILD progress message over the interactive shell. Maintainer directed to merged PR #753 (CRAFT-871), which pauses the emitter during user-requested shells; shipped in charmcraft 1.7 (candidate) as of 2022-05-30. | |
| #58 Implement "--shell", "--shell-after" and "--debug" | craft-application | closed | Implemented --shell, --shell-after and --debug support through merged PR #436 (commit ab55ec81). | |
| #4963 Support `--shell` and `--shell-after` for `snapcraft pack` | snapcraft | closed | Restored --shell and --shell-after for snapcraft pack via merged craft-application#436 (ab55ec81); the fix shipped in Snapcraft 8.4.1. | |
| #4959 `--debug` does not enter a shell for failures during post-prime or packing | snapcraft | closed | Fixed in Snapcraft 8.4.1: core24 --debug now opens a shell after post-prime or packing failures via craft-application PR #436 (ab55ec81). |