← Back to issue list

feat: replace ServiceFactory.set_kwargs with ServiceFactory.update_kwargs

View original Github issue

Metadata

Project
craft-application
Number
#440
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged following approval by two reviewers and passing CI checks. Replaces ServiceFactory.set_kwargs with ServiceFactory.update_kwargs across three files (+73/-4 lines) to standardize the service configuration API.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval by two reviewers and passing CI checks. Replaces ServiceFactory.set_kwargs with ServiceFactory.update_kwargs across three files (+73/-4 lines) to standardize the service configuration API.
qwen3.6-35b-a3b-mtp-q6 Merged the feature replacing ServiceFactory.set_kwargs with ServiceFactory.update_kwargs. This refactors the service factory API to use update_kwargs for keyword arguments. The change was accepted and closed without further discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#660 feat: mark ServiceFactory.set_kwargs() as deprecated craft-application merged Merged after three approvals and passing CI. Updates ServiceFactory.set_kwargs() from pending to officially deprecated, changing only the warning type without altering behavior.
77%