← Back to issue list

feat: mark ServiceFactory.set_kwargs() as deprecated

View original Github issue

Metadata

Project
craft-application
Number
#660
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after three approvals and passing CI. Updates ServiceFactory.set_kwargs() from pending to officially deprecated, changing only the warning type without altering behavior.

Suggested action:

No scores available.

Issue body

This moves set_kwargs() from pending deprecation to deprecated. It doesn't change any behaviour other than the type of warning that it raises. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after three approvals and passing CI. Updates ServiceFactory.set_kwargs() from pending to officially deprecated, changing only the warning type without altering behavior.
qwen3.6-35b-a3b-mtp-q6 Merged update marking ServiceFactory.set_kwargs() as deprecated, shifting its warning type from pending to deprecated without behavioral changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#440 feat: replace ServiceFactory.set_kwargs with ServiceFactory.update_kwargs craft-application merged Merged following approval by two reviewers and passing CI checks. Replaces ServiceFactory.set_kwargs with ServiceFactory.update_kwargs across three files (+73/-4 lines) to standardize the service configuration API.
77%