fix(models): coerce numbers to strings by default (#450)
Metadata
Current evaluation
Merged #450’s model fix in #459 (commit f175c968), restoring numeric-to-string coercion needed by downstream snapcraft#5017.
Resolution: closed resolved
Reason: PR #459 merged after approval as commit f175c968. It restored Pydantic’s coerce_numbers_to_str=True default in CraftBaseModel and carried the unreleased #450 fix into the required release line.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
#450 hasn't been released yet. I need it for https://github.com/canonical/snapcraft/issues/5017.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #450’s model fix in #459 (commit f175c968), restoring numeric-to-string coercion needed by downstream snapcraft#5017. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-application PR #459, restoring default number-to-string coercion in models to unblock canonical/snapcraft#5017. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix coercing numbers to strings by default in the models module. Approved by two reviewers with passing CI checks. The single-file change (+12/-0 lines) unblocks snapcraft issue #5017. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#450
(confidence 100%)
Original fix whose numeric-to-string coercion change was carried into the required release line.
-
Related To:
canonical/snapcraft#5017
(confidence 100%)
Downstream issue cited as requiring the unreleased model fix.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #450 fix(models): coerce numbers to strings by default | craft-application | merged | Merged #450 in dc1928f2, restoring numeric-to-string coercion in CraftBaseModel so numeric YAML values are accepted by string fields. | |
| #50 fix(models): coerce numbers to strings | craft-grammar | merged | Merged PR #50 as commit 3c244fa, restoring numeric-to-string coercion in model configurations across four files. | |
| #816 fix(parts): coerce numbers in input model | craft-parts | merged | Merged in commit 8b6d8db1 via #816, adding numeric-to-string coercion to the parts input model for the craft-parts portion of canonical/snapcraft#4978. | |
| #46 fix: coerce numbers to strings | craft-grammar | closed | Closed unmerged as ineffective; merged PR canonical/craft-grammar#50 restored numeric-to-string coercion in commit 3c244fa. |