← Back to issue list

fix(models): coerce numbers to strings

View original Github issue

Metadata

Project
craft-grammar
Number
#50
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #50 as commit 3c244fa, restoring numeric-to-string coercion in model configurations across four files.

Resolution: closed resolved

Reason: The change was merged into the mainline as commit 3c244fa, titled "fix: coerce numbers to strings (#50)", after approval by two reviewers.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #50 as commit 3c244fa, restoring numeric-to-string coercion in model configurations across four files.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-grammar#50, restoring numeric-to-string coercion in models. Approved by two reviewers, with changes across four files.
stealth/space-bunny-alpha — closed resolved Merged PR #450 as dc1928f2, restoring default numeric-to-string coercion in models to address canonical/snapcraft#4978 and #5017.
qwen/qwen3.6-35b-a3b — — Merged a fix coercing numeric values to strings in the models module. Approved by two reviewers, the change updated four files (+156/-52 lines), resolving type conversion issues in the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#450 fix(models): coerce numbers to strings by default craft-application merged Merged #450 in dc1928f2, restoring numeric-to-string coercion in CraftBaseModel so numeric YAML values are accepted by string fields.
82%
#459 fix(models): coerce numbers to strings by default (#450) craft-application merged Merged #450’s model fix in #459 (commit f175c968), restoring numeric-to-string coercion needed by downstream snapcraft#5017.
80%