← Back to issue list

tests: test number coercion

View original Github issue

Metadata

Project
craft-application
Number
#465
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after canonical/craft-grammar#50 fixed numeric-to-string coercion upstream, making the test-only changes in craft-application#465 obsolete.

Resolution: closed superseded

Reason: canonical/craft-grammar#50 merged the coercion fix as commit 3c244fa. The maintainer cited that upstream fix when closing this test-only PR without merging it.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- This is still failing and I haven't figured out why!

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged after canonical/craft-grammar#50 fixed numeric-to-string coercion upstream, making the test-only changes in craft-application#465 obsolete.
stealth/space-bunny-alpha — closed superseded Test-only PR adding number-coercion tests; closed unmerged by author mr-cal after the defect was fixed upstream in canonical/craft-grammar#50 (commit 3c244fa), making the local test unnecessary.
stealth/space-bunny-alpha — closed superseded Closed unmerged after the number-coercion defect was fixed upstream by merged canonical/craft-grammar#50; this test-only PR was no longer needed.
qwen/qwen3.6-35b-a3b — — Closed as the root cause was fixed upstream in craft-grammar pull request 50. The test changes were not merged here since the issue was resolved separately.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#46 fix: coerce numbers to strings craft-grammar closed Closed unmerged as ineffective; merged PR canonical/craft-grammar#50 restored numeric-to-string coercion in commit 3c244fa.
75%