← Back to issue list

Application: treat CraftError-like exceptions as CraftErrors

View original Github issue

Metadata

Project
craft-application
Number
#479
Type
issue
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

CraftError-like exceptions bubbling to Application were reported as internal errors; PR #695 added a craft_platforms.CraftError branch in handle_runtime_error, so this appears resolved but the issue remains open.

Suggested action: close resolved

Reason: handle_runtime_error in craft_application/util/logging.py now contains a craft_platforms.CraftError branch that converts details/resolution into craft_cli.CraftError, added by PR #695 (commit deca76bd). Issue #479's own metadata confirms it was fixed by that PR.

Evaluated by: mr-cal-bot

Impact: 45 Quick Win: 24 Complexity: 25 Confidence: 85 Actionability: 70

Issue body

### What needs to get done Exceptions that follow the message/resolution pattern of CraftError should be treated as CraftErrors if they're bubbled up to the application ### Why it needs to get done Right now these are converted to internal errors, which is incorrect.

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest
Impact: 45
Quick Win: 24
Complexity: 25
Confidence: 85
Actionability: 70
close resolved CraftError-like exceptions bubbling to Application were reported as internal errors; PR #695 added a craft_platforms.CraftError branch in handle_runtime_error, so this appears resolved but the issue remains open.
stealth/space-bunny-alpha
Impact: 38
Quick Win: 23
Complexity: 28
Confidence: 88
Actionability: 85
close resolved CraftError-like exceptions bubbling up to the Application were reported as internal errors instead of CraftErrors. Fixed by PR #695 (commit deca76bd), which added a craft_platforms.CraftError branch in handle_runtime_error; issue is still open.
qwen/qwen3.6-35b-a3b
Impact: 70
Quick Win: 39
Complexity: 30
Confidence: 90
Actionability: 80
close resolved Issue requesting duck-typing for CraftError-like exceptions. Resolved by merged PR #695 which implements catching and converting craft-like errors to CraftError instances.
qwen/qwen3.8-27b
Impact: 50
Quick Win: 30
Staleness: 75
Complexity: 40
Confidence: 70
Support Request: 0
needs triage Application should treat exceptions following CraftError's message/resolution pattern as CraftErrors instead of converting them to internal errors. Open since 2023, last activity 465 days ago, no labels or maintainer response beyond a Jira sync bot comment.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 20
Confidence: 80
Support Request: 10
needs triage Exceptions matching CraftError patterns are incorrectly handled as internal errors. Untriaged, inactive for over a year, awaiting maintainer review.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 25
Confidence: 65
Support Request: 10
needs triage Unlabelled issue requesting that CraftError-like exceptions be handled as CraftErrors instead of internal errors. Currently inactive for over a year with only a Jira sync bot comment.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: craft-application#695 (confidence 90%)

    Merged PR added the craft_platforms.CraftError branch to handle_runtime_error; issue metadata confirms the fix.

  • Related To: craft-application#693 (confidence 80%)

    Original craft-platforms errors issue fixed by the same PR.

Related issues

Issue Project State Summary Similarity
#695 fix(Application): catch all craft-like errors craft-application merged Merged PR #695 in commit deca76bd, converting craft-like application errors into CraftError instances instead of internal errors and fixing #693.
74%
#693 craft-platforms errors aren't caught craft-application closed Craft-platforms errors now display as normal Craft errors instead of internal errors, fixed by merged PR #695 (commit deca76bd).
71%