← Back to issue list

feat: pass the app_config to pre_parse_args()

View original Github issue

Metadata

Project
craft-application
Number
#541
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #541 (commit 384153db) passed app_config to pre_parse_args(), making command config available during fill_parser() help rendering and fixing #530.

Resolution: closed resolved

Reason: PR #541 was merged as commit 384153db. It ensures self.config exists while generating help output, resolving the init-command help failure reported in #530.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This lets commands be able to always rely on `self.config` existing, even when running `fill_parser()` for help output. Fixes #530 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #541 (commit 384153db) passed app_config to pre_parse_args(), making command config available during fill_parser() help rendering and fixing #530.
stealth/space-bunny-alpha — closed resolved Merged PR #541 via commit 384153db passes app_config to pre_parse_args(), keeping self.config available during help generation and fixing #530.
stealth/space-bunny-alpha — closed resolved Merged PR #541 passes app_config to pre_parse_args(), ensuring commands have self.config available during fill_parser() help output and fixing #530.
qwen/qwen3.6-35b-a3b — — Merged. Passes app_config to pre_parse_args() to ensure self.config exists during fill_parser() for help output, resolving #530. Approved by two reviewers with passing CI checks.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#295 feat: support app_config in pre_parse_args() craft-cli merged Merged PR #295 as commit 8bfac83, adding app_config support to pre_parse_args(), including help generation; released in 2.9.0 and fixes #292.
83%