feat: support app_config in pre_parse_args()
Metadata
Current evaluation
Merged PR #295 as commit 8bfac83, adding app_config support to pre_parse_args(), including help generation; released in 2.9.0 and fixes #292.
Resolution: closed resolved
Reason: PR #295 was approved and merged as commit 8bfac83. It makes application configuration available during pre-parsing and command help generation; the 2.9.0 changelog records the feature.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This lets the commands of a given application access the configuration dict during fill_parser() even when building the help message, like in `app cmd -h`. Of course, this can only be used in cases where the configuration dict contains data that the application already has at pre_parse_args()-time.
Fixes #292
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #295 as commit 8bfac83, adding app_config support to pre_parse_args(), including help generation; released in 2.9.0 and fixes #292. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #295 as commit 8bfac83, allowing pre_parse_args() commands to access app_config, including during help generation; fixes #292. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a feature enabling app_config access during pre_parse_args(), resolving issue #292. Approved by two reviewers, passed CI, and modified three files with 92 additions and 15 deletions. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-cli#292
(confidence 100%)
PR #295 explicitly states that it fixes issue #292.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #541 feat: pass the app_config to pre_parse_args() | craft-application | merged | Merged PR #541 (commit 384153db) passed app_config to pre_parse_args(), making command config available during fill_parser() help rendering and fixing #530. |