fix(remote-build): don't cleanup after a timeout
Metadata
Current evaluation
Merged in canonical/craft-application#625 (7c636d3a): remote builds are preserved after timeouts, and nonexistent --build-id messaging was removed for 4.8.3.
Resolution: closed resolved
Reason: PR #625 was merged as commit 7c636d3a, stopping cleanup after a timeout and resolving #618 and #619.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This stops the remote builder from trying to clean up after a timeout.
It also removes where it talks about a `--build-id` option that doesn't exist.
Fixes #618
Fixes #619
CRAFT-4040
CRAFT-4025
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-application#625 (7c636d3a): remote builds are preserved after timeouts, and nonexistent --build-id messaging was removed for 4.8.3. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-application#625 as 7c636d3a, preserving remote builds after timeouts and removing nonexistent --build-id messaging; planned for 4.8.3. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-application PR #625 (commit 7c636d3a) stopped remote-build cleanup after timeouts and removed nonexistent --build-id documentation, resolving #618 and #619. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #625 (7c636d3a): remote builds no longer clean up after a timeout, and documentation for the nonexistent --build-id option was removed. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix preventing remote builder cleanup after timeouts and removing references to a non-existent --build-id option. Approved by two reviewers, passed CI, and rebased to main for release 4.8.3. Resolves #618 and #619. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-application#618
(confidence 100%)
The timeout cleanup bug was fixed by PR #625.
-
Likely Fixed By:
canonical/craft-application#619
(confidence 100%)
PR #625 removed messaging about the nonexistent --build-id option.
-
Related To:
canonical/snapcraft#5223
(confidence 90%)
A maintainer noted that Snapcraft must refactor or port this remote-build improvement.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #618 Remote build does cleanup even after a timeout | craft-application | closed | Remote-build cleaned up build resources after a --launchpad-timeout; fixed by PR #625 (commit 7c636d3a) which raises TimeoutError so the handler returns exit 75 without cleanup. Shipped in 4.8.3. |