← Back to issue list

Remote build does cleanup even after a timeout

View original Github issue

Metadata

Project
craft-application
Number
#618
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Remote-build cleaned up build resources after a --launchpad-timeout; fixed by PR #625 (commit 7c636d3a) which raises TimeoutError so the handler returns exit 75 without cleanup. Shipped in 4.8.3.

Resolution: closed resolved

Reason: Commit 7c636d3a ("fix(remote-build): don't cleanup after a timeout (#625)") made remote.py raise TimeoutError from the monitoring path so it is caught by the handler that prints the resume hint and returns 75, skipping builder.cleanup(). The changelog commit 9048280e (#627) prepared the 4.8.3 release containing the fix.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description This: https://github.com/canonical/craft-application/blob/657d1fe9497c0e9c5c2a4d237b25b9b666080eeb/craft_application/commands/remote.py#L179-L189 should raise the TimeoutError to get caught here: https://github.com/canonical/craft-application/blob/657d1fe9497c0e9c5c2a4d237b25b9b666080eeb/craft_application/commands/remote.py#L137 and not do cleanup ### To Reproduce `rockcraft remote-build --launchpad-timeout=180` ### part yaml ```shell ``` ### Relevant log output ```shell n/a ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Remote-build cleaned up build resources after a --launchpad-timeout; fixed by PR #625 (commit 7c636d3a) which raises TimeoutError so the handler returns exit 75 without cleanup. Shipped in 4.8.3.
stealth/space-bunny-alpha — closed resolved Maintainer-reported bug where remote-build ran cleanup after a Launchpad timeout. Fixed by PR #625 (commit 7c636d3a), which raises TimeoutError and returns exit 75 with a --recover hint instead of cleaning up.
stealth/space-bunny-alpha — closed resolved Fixed in canonical/craft-application#625 (commit 7c636d3a): remote builds now preserve resources after timeouts instead of running cleanup. Planned for version 4.8.3.
qwen/qwen3.6-35b-a3b — — Closed without resolution. Remote build cleanup incorrectly runs after a timeout instead of raising TimeoutError. No fix or pull request was submitted, indicating the bug was abandoned.
qwen/qwen3.6-35b-a3b — — Closed without explicit resolution details. The issue reported remote build cleanup runs after a timeout due to a missing TimeoutError raise. A Jira ticket was created for tracking.
qwen/qwen3.6-35b-a3b — — Closed and deferred to internal tracking via Jira ticket CRAFT-4025. No public fix, merge, or resolution was provided. The timeout cleanup bug remains unaddressed in the repository.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-application#625 (confidence 97%)

    Merged PR fixing the exact code path flagged in the issue; commit 7c636d3a 'fix(remote-build): don't cleanup after a timeout'.

  • Related To: canonical/craft-application#627 (confidence 80%)

    Changelog commit 9048280e 'docs(changelog): prepare 4.8.3 release' following the fix, indicating the change was released in 4.8.3.

  • Related To: canonical/craft-application#623 (confidence 35%)

    Commit 600e733e landed immediately before the fix in remote.py, indicating active concurrent work on the same command.

Related issues

Issue Project State Summary Similarity
#2845 remote-build: configurable timeout/deadline for starting and monitoring build snapcraft merged PR #2845 merged as ba92ac5f7, restoring --launchpad-timeout as a shared deadline for starting and monitoring remote builds and clarifying timeout failures.
74%
#2709 On timeout, `remote-build` should return the artifacts that have successfully finished building charmcraft open Feature request: `remote-build` returns 75 on --launchpad-timeout without fetching already-successful artifacts; maintainer-linked to the pending --build-for request #2467. Still open and unlabelled.
74%
#625 fix(remote-build): don't cleanup after a timeout craft-application merged Merged in canonical/craft-application#625 (7c636d3a): remote builds are preserved after timeouts, and nonexistent --build-id messaging was removed for 4.8.3.
74%
#4426 fix(remote-build): parse `--launchpad-timeout` argument snapcraft merged Merged #4426 as c6f41daa8, restoring --launchpad-timeout parsing for the new remote builder. Companion #4427 fixed the fallback builder, resolving #4397.
73%