← Back to issue list

feat!: replace current secrets implementation with a secrets service

View original Github issue

Metadata

Project
craft-application
Number
#635
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Rejected unmerged: maintainer lengau closed the proposed secrets-service replacement with “We're not supporting secrets,” leaving the existing implementation unchanged.

Resolution: closed not a bug

Reason: The PR was closed without merge after the maintainer explicitly stated that secrets are not supported. No resolving commit or superseding PR was identified.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed not a bug Rejected unmerged: maintainer lengau closed the proposed secrets-service replacement with “We're not supporting secrets,” leaving the existing implementation unchanged.
stealth/space-bunny-alpha — closed stale Secrets-service replacement was closed unmerged; maintainer lengau said "We're not supporting secrets," leaving the current implementation unchanged.
qwen/qwen3.6-35b-a3b — — Proposed secrets service replacement was closed and rejected. The maintainer stated the project will not support secrets, abandoning the changes without review or merge.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 85
Confidence: 90
close stale Proposes a breaking architectural change to replace the secrets implementation with a dedicated service. The PR is 17 months old, has no reviews, CI checks, or comments, and remains in draft/pending state.
qwen3.6-35b-a3b-mtp-q6
Staleness: 98
Complexity: 80
Confidence: 90
close stale PR proposes replacing the current secrets implementation with a new secrets service. It remains a draft with no description, reviews, or activity for over 14 months.

Update history

Date Change
closed

Related issues

Issue Project State Summary Similarity
#657 feat!(secrets): remove secrets craft-application merged Merged PR #657 in commit ad52b56b, removing built-in secrets support; applications can instead integrate secrets through the prototype secrets service.
74%