feat!(secrets): remove secrets
Metadata
Current evaluation
Merged PR #657 in commit ad52b56b, removing built-in secrets support; applications can instead integrate secrets through the prototype secrets service.
Resolution: closed resolved
Reason: PR #657 was merged into the main branch as commit ad52b56b after approval from two reviewers. The commit removes built-in secrets support across eight files.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Removes the ability to use secrets. This can be added to applications if necessary using the prototype secrets service.
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #657 in commit ad52b56b, removing built-in secrets support; applications can instead integrate secrets through the prototype secrets service. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-application#657 (commit ad52b56b), removing built-in secrets support across 8 files. Applications can add secrets through the prototype service. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-application#657 (commit ad52b56b), removing built-in secrets; applications may implement the prototype secrets service instead. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals and passing CI. The change removes built-in secrets functionality, deleting 595 lines across eight files. Applications can instead implement the prototype secrets service if needed. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#1066
(confidence 96%)
Later added a callback mechanism for applications and plugins to provide secrets to fetch-service sessions.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #483 feat(secrets): support for 'basic' secrets | fetch-service | merged | Merged PR #483 as commit 83d6fa6, adding support for basic-auth secrets, including validation, HTTP Authorization header injection, session plumbing, and tests. | |
| #635 feat!: replace current secrets implementation with a secrets service | craft-application | closed | Rejected unmerged: maintainer lengau closed the proposed secrets-service replacement with “We're not supporting secrets,” leaving the existing implementation unchanged. | |
| #185 feat: add secrets API | craft-cli | merged | Merged PR #185 (commit e988947) adds Emitter.set_secrets(), masking registered strings as "*****" across emitter messages, log calls, spinner, progress bar and streaming brief prefix via Printer._apply_secrets. | |
| #104 feat: support build-secrets in managed-mode | craft-application | merged | Merged managed-mode build-secret support in #104 via commit 8c6c0475, encoding host secrets and decoding them in managed instances to re-render project secrets. | |
| #50 spec for handling build-time secrets | craft-application | closed | Build-time secrets were delivered through a secrets API and application rendering; managed-mode support followed in #104. | |
| #378 feat: enable build-secrets | rockcraft | merged | Merged PR #378 enabled build-secrets support, landing a six-file (+48/-4) change on feature/build-secrets after approval by two reviewers. |