← Back to issue list

feat!(secrets): remove secrets

View original Github issue

Metadata

Project
craft-application
Number
#657
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals and passing CI. The change removes built-in secrets functionality, deleting 595 lines across eight files. Applications can instead implement the prototype secrets service if needed.

Suggested action:

No scores available.

Issue body

Removes the ability to use secrets. This can be added to applications if necessary using the prototype secrets service. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals and passing CI. The change removes built-in secrets functionality, deleting 595 lines across eight files. Applications can instead implement the prototype secrets service if needed.
qwen3.6-35b-a3b-mtp-q6 Merged a breaking change removing built-in secrets functionality. The maintainer notes secrets can be reintroduced via a prototype service if needed. The change passed linting and tests without comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#483 feat(secrets): support for 'basic' secrets fetch-service merged Merged feature adding support for basic secrets. Approved by three reviewers, passed all CI checks, and modified 14 files with 240 additions and 14 deletions.
77%
#635 feat!: replace current secrets implementation with a secrets service craft-application closed Proposed secrets service replacement was closed and rejected. The maintainer stated the project will not support secrets, abandoning the changes without review or merge.
75%
#185 feat: add secrets API craft-cli merged Merged the secrets API feature, adding Emitter.set_secrets to mask sensitive strings across all CLI outputs. Approved by two reviewers, passed CI checks, and achieved 100% diff coverage. Resolves issue 184.
71%
#104 feat: support build-secrets in managed-mode craft-application merged Merged into main. Implements build-secrets support in managed-mode by encoding secrets into the host-application environment for the managed instance to decode and re-render. Approved by two reviewers, passed CI, and achieved 100% diff coverage.
70%