perf(tests): remove duplicate fixtures
Metadata
Current evaluation
Closed unmerged by lengau: the plugin half landed via #653 (5d7a6fe0); the duplicate-fixture cleanup (default_app_metadata, app_metadata_docs) was deferred to a fresh PR after ~19 months of no rebase.
Resolution: closed superseded
Reason: Closing comment from lengau (2026-09-30) states the plugin portion landed via #653 (merged as 5d7a6fe0) and the remaining fixture cleanup is better done as a new PR; tests/conftest.py at e2f9f3ba still defines both default_app_metadata (line 227) and app_metadata_docs (line 264), confirming the cleanup was never merged.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Requires #645
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged by lengau: the plugin half landed via #653 (5d7a6fe0); the duplicate-fixture cleanup (default_app_metadata, app_metadata_docs) was deferred to a fresh PR after ~19 months of no rebase. | |
| qwen/qwen3.8-27b | — | closed superseded | Closed unmerged by the maintainer: the pytest-plugin half landed via #653 (commit 5d7a6fe0), and the remaining fixture cleanup (default_app_metadata, app_metadata_docs) was deferred to a fresh PR since the branch was 19 months out of date. | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged after six days with no review, comments, CI, or recorded replacement; it depended on pytest plugin PR #645. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
2
Complexity:
25
Confidence:
55
Actionability:
20
|
close stale | Test cleanup PR removing duplicate fixtures across 13 files. Requires merged PR #645 (pytest plugin). Inactive for 577 days with no review activity or CI runs. | |
| qwen/qwen3.8-27b |
Impact:
20
Quick Win:
12
Staleness:
85
Complexity:
40
Confidence:
65
|
close stale | Removes duplicate test fixtures from tests/conftest.py now that the pytest plugin (merged in #645/#653) provides them. 564 days old, 0 comments, no review, pending. Codebase has evolved significantly since. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
85
Complexity:
20
Confidence:
80
|
keep open | Refactors test suite by removing duplicate fixtures across 13 files. Currently pending review with zero comments, no CI status, and explicitly blocked on PR #645. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
90
Complexity:
15
Confidence:
80
|
keep open | Removes duplicate test fixtures to improve test performance. Inactive for over 1.5 years with zero comments and blocked on PR #645. |
Update history
| Date | Change |
|---|---|
| updated | |
| closed |
Related work
-
Superseded By:
canonical/craft-application#653
(confidence 92%)
Merged as 5d7a6fe0; the maintainer says the plugin half of #647 landed here.
-
Duplicate Of:
canonical/craft-application#645
(confidence 60%)
Same pytest plugin change (also merged as 5d7a6fe0) that #647 declared as a prerequisite.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #199 tests: refactor plugin dependency tests | craft-parts | merged | PR #199 was merged, replacing redundant plugin dependency-test fixtures with a fixture factory; commit c668c180 landed via merge commit a3c5e087. |