← Back to issue list

perf(tests): remove duplicate fixtures

View original Github issue

Metadata

Project
craft-application
Number
#647
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Removes duplicate test fixtures from tests/conftest.py now that the pytest plugin (merged in #645/#653) provides them. 564 days old, 0 comments, no review, pending. Codebase has evolved significantly since.

Suggested action: close stale

Reason: 557 days of inactivity with zero comments or review, authored by a maintainer who has not revisited it. The dependency (pytest plugin, merged) is in place, but tests/conftest.py has had ~30+ commits since this PR was opened (e.g. #644, #653, #655, #666, #674, #677, #686, #725, #786, #812, #829, #850, #868, #872, #907, #1047, #1084), making the +382/-123 diff across 13 files effectively obsolete and requiring a full rework. The underlying goal (deduplicating fixtures) remains valid but should be addressed in a fresh PR against current code.

Impact: 20 Quick Win: 12.0 Staleness: 85 Complexity: 40 Confidence: 65

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Requires #645

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 20
Quick Win: 12.0
Staleness: 85
Complexity: 40
Confidence: 65
close stale Removes duplicate test fixtures from tests/conftest.py now that the pytest plugin (merged in #645/#653) provides them. 564 days old, 0 comments, no review, pending. Codebase has evolved significantly since.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 20
Confidence: 80
keep open Refactors test suite by removing duplicate fixtures across 13 files. Currently pending review with zero comments, no CI status, and explicitly blocked on PR #645.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 15
Confidence: 80
keep open Removes duplicate test fixtures to improve test performance. Inactive for over 1.5 years with zero comments and blocked on PR #645.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 10
Confidence: 70
close stale Removes duplicate test fixtures to improve test performance. Open 488 days ago with zero comments and no activity since day 7. Currently blocked on PR #645 and awaiting review or rebase.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: craft-application#645 (confidence 70%)

    The pytest plugin PR (merged) introduced the shared fixtures that made the conftest.py copies redundant. This PR was the follow-up cleanup, but was never completed.

Related issues

No related issues found above the similarity threshold.