← Back to issue list

tests: refactor plugin dependency tests

View original Github issue

Metadata

Project
craft-parts
Number
#199
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI. Refactored plugin dependency tests by replacing redundant fixtures with a fixture factory in conftest.py, optimizing 4 files. Addressed reviewer feedback regarding test configuration.

Suggested action: —

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Replace redundant fixtures with a fixture factory. (CRAFT-1027)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI. Refactored plugin dependency tests by replacing redundant fixtures with a fixture factory in conftest.py, optimizing 4 files. Addressed reviewer feedback regarding test configuration.
qwen3.6-35b-a3b-mtp-q6 — — Merged a refactoring of plugin dependency tests that replaces redundant fixtures with a fixture factory using conftest.py, addressing CRAFT-1027.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#947 tests: deduplicate tests for python-based plugins craft-parts merged Merged changes that deduplicate tests for Python-based plugins, resolving #935 and CRAFT-3807. Approved by three reviewers, passed CI, and modified six files with a net reduction of 98 lines.
73%
#1791 tests: python plugin integration tests moved to a separate suite snapcraft merged Merged. Python plugin integration tests were split into a separate suite to prevent timeout failures in the main plugins test suite. Approved by reviewer, passed CI, and modified seven files.
73%
#1387 test: add integration tests for make plugin craft-parts merged Merged integration tests for the make plugin covering basic functionality and parameter forwarding. Addressed review feedback by refactoring tests, fixing DESTDIR failures, and updating commit messages. Resolved conflicts and passed CI.
71%
#1286 test: run all plugin tests with partitions craft-parts merged Merged after two approvals and passing CI. The change refactors plugin test execution to run all tests with partitions enabled across 26 files. Resolves CRAFT-4767.
70%