← Back to issue list

tests: refactor plugin dependency tests

View original Github issue

Metadata

Project
craft-parts
Number
#199
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #199 was merged, replacing redundant plugin dependency-test fixtures with a fixture factory; commit c668c180 landed via merge commit a3c5e087.

Resolution: closed resolved

Reason: Merged into main in a3c5e087, resolving CRAFT-1027 by refactoring the tests to use a shared conftest.py fixture factory.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Replace redundant fixtures with a fixture factory. (CRAFT-1027)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #199 was merged, replacing redundant plugin dependency-test fixtures with a fixture factory; commit c668c180 landed via merge commit a3c5e087.
stealth/space-bunny-alpha — closed resolved Merged PR #199 replaced redundant plugin dependency test fixtures with a fixture factory in conftest.py, reducing test boilerplate across four files (+70/-104 lines).
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI. Refactored plugin dependency tests by replacing redundant fixtures with a fixture factory in conftest.py, optimizing 4 files. Addressed reviewer feedback regarding test configuration.
qwen3.6-35b-a3b-mtp-q6 — — Merged a refactoring of plugin dependency tests that replaces redundant fixtures with a fixture factory using conftest.py, addressing CRAFT-1027.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1014 tests: reorganize plugin tests into subdirectory. snapcraft merged Merged #1014 as d97c00e8f, moving plugin unit tests into a dedicated subdirectory to make the suite manageable and resolve LP #1651903.
72%
#647 perf(tests): remove duplicate fixtures craft-application closed Closed unmerged by lengau: the plugin half landed via #653 (5d7a6fe0); the duplicate-fixture cleanup (default_app_metadata, app_metadata_docs) was deferred to a fresh PR after ~19 months of no rebase.
72%
#309 tests: use fixture for base_configuration craft-providers merged Merged PR #309 as commit f4042c9, refactoring tests to use a reusable base_configuration fixture as a prerequisite for CRAFT-1767.
72%
#3432 spread tests: remove legacy plugin tests snapcraft merged PR #3432 (commit 950fa2508, f2c9caa04) merged: deleted 665 lines of legacy plugin spread tests across 29 files, removing outdated plugin coverage without affecting code coverage (90.83%).
71%
#831 Fixed/simplified some tests to isolate them of underlying apt. charmcraft merged Merged PR #831 removed apt-dependent execution from parts/build tests, replacing a null plugin and simplifying build fixtures; merged as commit 6418a586.
70%