← Back to issue list

feat(test): create partitioncraft

View original Github issue

Metadata

Project
craft-application
Number
#673
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after dual approval, introducing partitioncraft to testcraft with basic lifecycle spread tests. One reviewer noted tests should be fixed before merge, but the changes were ultimately merged.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- This creates `partitioncraft`, a minimal app that uses partitions. It also adds it to the `testcraft` snap and runs a basic lifecycle spread test for it. Requires #666

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after dual approval, introducing partitioncraft to testcraft with basic lifecycle spread tests. One reviewer noted tests should be fixed before merge, but the changes were ultimately merged.
qwen3.6-35b-a3b-mtp-q6 Merged. Introduces partitioncraft, a minimal app utilizing partitions, to the testcraft snap alongside a basic lifecycle spread test. Requires PR #666. Approved pending test fixes, then merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#88 feat: create craft partitions from structure items imagecraft merged Merged implementation of dynamic craft partition creation from structure items in the Volumes section, resolving issue #81. Approved by two reviewers and passed CI checks across 12 files.
73%
#493 partitions: validate usage of partitions in parts craft-parts merged Implemented partition validation for filepaths in the organize, overlay, stage, and prime keywords within parts. Merged after reviewer approval and passing CI checks, modifying seven files to resolve CRAFT-1844.
70%
#826 feat(partitions): custom error for nonexistent partition craft-parts merged Merged a feature introducing a custom error for nonexistent partitions to improve error handling in corncraft. Approved by three reviewers, passed CI, and modified three files. Temporary linter failures from cmake.org downtime were resolved prior to merge.
70%