← Back to issue list

partitions: add feature and validation

View original Github issue

Metadata

Project
craft-parts
Number
#489
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged. Implements the partitions feature and validation for LifecycleManager, adding a new parameter, input validation, error handling, and integration tests. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- - The partitions feature can be enabled - LifecycleManager can accept a new parameter, `partitions` - The list of partitions is validated and errors are appropriately raised - Integration tests that only ensures craft-parts works as expected when partitions are enabled (no changes from default behavior) I tried my best to follow how overlay testing is done (how test directories are laid out, which tests are reused, etc). (CRAFT-1843)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Implements the partitions feature and validation for LifecycleManager, adding a new parameter, input validation, error handling, and integration tests. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds partitions feature and validation to LifecycleManager, including parameter acceptance, error handling, and integration tests. Resolves CRAFT-1843.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#599 feat(partitions): validate namespaced partitions craft-parts merged Validates namespaced partitions during LifecycleManager initialization, resolving issue #595. Merged after approval by two reviewers, adding 248 lines and removing 22 across five files.
82%
#595 Parse and validate namespaced partitions craft-parts closed Fixed by implementing parsing and validation for namespaced partitions in LifecycleManager. Added error handling for invalid namespaces and partitions, enforcing lowercase letter and hyphen constraints. Resolved via merged pull request #599.
72%
#493 partitions: validate usage of partitions in parts craft-parts merged Implemented partition validation for filepaths in the organize, overlay, stage, and prime keywords within parts. Merged after reviewer approval and passing CI checks, modifying seven files to resolve CRAFT-1844.
72%
#292 feat: expose partitions to the lifecycle service craft-application merged Merged the feature exposing partitions to the lifecycle service. Approved by two reviewers, the change modifies five files (+117/-17 lines) and integrates the new API into the codebase.
72%
#4493 feat(lifecycle): conditionally enable partitions snapcraft merged Merged after approval and CI checks. Conditionally enables partitions for components on core24 or newer bases, generates partitions from definitions, and adds environment variables. Resolves #4463 and #4465.
70%