partitions: add feature and validation
Metadata
Current evaluation
Merged as commit d363fa7c, adding the opt-in partitions feature to LifecycleManager/Dirs, partition name validation with new partition errors, and integration tests for CRAFT-1843. Follow-up PRs #493, #497 and #517 extended it.
Resolution: closed resolved
Reason: PR #489 was approved by two reviewers and merged to main as commit d363fa7c, landing the partitions feature flag, LifecycleManager/Dirs 'partitions' parameter, validate_partition_names checks and integration tests. Follow-up work continued in #493, #497 and #517.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
- The partitions feature can be enabled
- LifecycleManager can accept a new parameter, `partitions`
- The list of partitions is validated and errors are appropriately raised
- Integration tests that only ensures craft-parts works as expected when partitions are enabled (no changes from default behavior)
I tried my best to follow how overlay testing is done (how test directories are laid out, which tests are reused, etc).
(CRAFT-1843)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit d363fa7c, adding the opt-in partitions feature to LifecycleManager/Dirs, partition name validation with new partition errors, and integration tests for CRAFT-1843. Follow-up PRs #493, #497 and #517 extended it. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #489 as d363fa7c, adding opt-in partition support, a LifecycleManager partitions parameter, validation and error handling, and integration tests for CRAFT-1843. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Implements the partitions feature and validation for LifecycleManager, adding a new parameter, input validation, error handling, and integration tests. Approved by two reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds partitions feature and validation to LifecycleManager, including parameter acceptance, error handling, and integration tests. Resolves CRAFT-1843. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#493
(confidence 85%)
Follow-up merged PR ed20df71 validating partition usage in parts' organize/overlay/stage/prime filepaths (CRAFT-1844).
-
Related To:
canonical/craft-parts#497
(confidence 80%)
Follow-up merged PR adding partition-compatible filepath utilities (CRAFT-1845).
-
Related To:
canonical/craft-parts#517
(confidence 80%)
Follow-up merged PR 16db872d wiring partitions into features and building binary outputs.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #599 feat(partitions): validate namespaced partitions | craft-parts | merged | Merged PR #599 as commit 06a5f999, adding namespaced partition validation during LifecycleManager initialization and fixing #595 (CRAFT-2032). | |
| #763 partitions feature documentation | craft-parts | merged | Merged developer-facing partitions documentation in commit cdcc9dbc, completing CRAFT-3030 after approval by two reviewers. | |
| #493 partitions: validate usage of partitions in parts | craft-parts | merged | Merged into craft-parts in commit ed20df71 (#493), adding validation of partition usage in filepaths for parts' organize, overlay, stage and prime keywords (CRAFT-1844). | |
| #4463 Enable craft-parts partitions feature | snapcraft | closed | Partitions support landed in merged PR #4493 (commit 070c7e995), enabling partition-backed component lifecycle data and completing #4463. | |
| #497 partitions: add utility to make partition compatible filepaths | craft-parts | merged | Merged #497, adding a utility that converts filepaths into partition-compatible paths for CRAFT-1845; landed as commit 20e994f8. | |
| #652 feat(partitions): clean partition directories | craft-parts | merged | Merged #652 via commit 797109e8, adding partition-directory cleanup when partitions are enabled and fixing #634 (CRAFT-2417). | |
| #600 feat(partitions): handle namespaced partitions in utils | craft-parts | merged | Merged into main in commit f387afa5 (PR #600), adding namespaced-partition handling to four partition utilities and resolving craft-parts#596. | |
| #754 Document Partitions | craft-parts | closed | Partitions documentation was added and the issue completed by merged PR canonical/craft-parts#763 in commit cdcc9dbc. | |
| #4493 feat(lifecycle): conditionally enable partitions | snapcraft | merged | Merged PR #4493 enabled partitions for devel/core24+ projects with components, added component lifecycle variables, and fixed #4463 and #4465; it replaced #4487. | |
| #528 partitions: make partitions optional in ProjectDirs | craft-parts | merged | Merged PR #528 made ProjectDirs.partitions optional; commit 545f82c9 records the resolution after approval by two reviewers. |