← Back to issue list

feat(services): add service setup method

View original Github issue

Metadata

Project
craft-application
Number
#69
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged into main after three approvals and passing CI. Introduces a setup method for service classes to handle pre-execution preparation. The change added 21 lines across three files with 100% diff coverage.

Suggested action:

No scores available.

Issue body

Service classes can override the `setup` method to run custom preparation before service execution, such as downloading additional assets or performing consistency checks. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main after three approvals and passing CI. Introduces a setup method for service classes to handle pre-execution preparation. The change added 21 lines across three files with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Introduces a setup method for service classes to run custom pre-execution preparation like asset downloads or consistency checks. Codecov confirmed 100% diff coverage upon merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#40 services: allow the service factory to be created before the project. craft-application merged Merged into main. Enables creating the service factory before the project. Approved by two reviewers, modified nine files with 65 additions and 13 deletions, and increased test coverage by 0.01%.
74%
#522 feat: add init service and init command craft-application merged Merged after two approvals and passing CI. Added the init service and command with profile support, resolving #452 and #508 and creating #530. The 19-file change includes tests and bug fixes discovered during development.
70%