services: allow the service factory to be created before the project.
Metadata
Current evaluation
Merged into main. Enables creating the service factory before the project. Approved by two reviewers, modified nine files with 65 additions and 13 deletions, and increased test coverage by 0.01%.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. Enables creating the service factory before the project. Approved by two reviewers, modified nine files with 65 additions and 13 deletions, and increased test coverage by 0.01%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main, enabling service factory initialization prior to project setup. The change achieved 100% diff coverage and increased overall code coverage by 0.01%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #75 refactor: pass the service factory to the services | craft-application | merged | Merged into main. Refactored service initialization to pass the ServiceFactory instance, enabling inter-service communication. Approved by two reviewers, passed CI, and achieved 100% diff coverage across 12 modified files. | |
| #35 application: ServiceFactory and main Application class | craft-application | merged | Merged following two reviewer approvals. The maintainer delayed integration to address missing unit test coverage, ensuring all CI checks passed before adding the ServiceFactory and main Application class implementations. | |
| #69 feat(services): add service setup method | craft-application | merged | Merged into main after three approvals and passing CI. Introduces a setup method for service classes to handle pre-execution preparation. The change added 21 lines across three files with 100% diff coverage. | |
| #646 feat!(services): add a project service | craft-application | merged | Merged the new ProjectService for handling projects. Changes replace the abstract service class, update the service factory and Application, and add unit and integration tests. Approved by two reviewers and passed CI. | |
| #1001 docs: Reference document for the Service Factory | craft-application | merged | Merged documentation update adding a reference guide for the Service Factory. Approved by two reviewers, passed all CI checks, and changed 24 lines across two files. Minor discussion on method signature rendering was resolved. |