fix: don't double up on timestamps in managed logs
Metadata
Current evaluation
Merged PR #691 (commit 1f120464), fixing duplicate managed-log timestamps by using craft-cli#331’s log-dumping API while retaining one outer retrieval timestamp.
Resolution: closed resolved
Reason: PR #691 was approved and merged as commit 1f120464. It removes the outer timestamp from individual inner-instance log lines, preventing duplicate timestamps during error log retrieval.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
In case of an error, the inner instance's logs get directly dumped into the outer instance's logs. This caused a double timestamp situation.
This PR removes the outer instance's timestamp and instead dumps the inner instance's logs like so:
```
[OUTER_TIMESTAMP] Logs retrieved from inner instance:
:: [INNER_TIMESTAMP] gcc main.c -o main
:: [INNER_TIMESTAMP] ...
```
Requires https://github.com/canonical/craft-cli/pull/331.
CRAFT-4331
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #691 (commit 1f120464), fixing duplicate managed-log timestamps by using craft-cli#331’s log-dumping API while retaining one outer retrieval timestamp. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged a fix for duplicate managed-log timestamps, prefixing inner logs with a retrieval header and using craft-cli#331’s log-dumping API. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged CRAFT-4331 fix: forwarding managed-instance error logs no longer adds outer timestamps to inner log lines, preventing duplicated timestamps. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the fix to prevent duplicate timestamps when inner-instance logs are forwarded to managed outer logs, preserving the inner timestamps. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for double timestamps in managed logs. Resolved by removing the outer instance timestamp and preserving inner instance timestamps during log dumping. Approved by two reviewers, passed CI, and merged. Depends on craft-cli#331. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-cli#331
(confidence 98%)
Its merged log-dumping API was required to emit inner logs without adding a second timestamp.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #649 Don't show double or triple timestamps | charmcraft | closed | Duplicate timestamp logging was fixed by making charm_builder.py a standalone script with plain stdout; PR #865 merged as commit 56242113, resolving the remaining double-timestamp case tracked in #750. |