← Back to issue list

feat(emitter): add a log dumping function

View original Github issue

Metadata

Project
craft-cli
Number
#331
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #331 as commit 839986b, adding external-log dumping to the emitter and a public read-only log_filepath property.

Resolution: closed resolved

Reason: PR #331 was merged into main at commit 839986b. It writes external logs directly to the emitter's log file and exposes log_filepath for consumer access and testing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? Adds a new function to dump external logs directly into the emitter's log file, bypassing printing to the terminal and giving better customization for log behavior in the future. It additionally adds a public `log_filepath` read-only property so consumers of the emitter can more easily access and test the contents of the log. Required by https://github.com/canonical/craft-application/pull/691.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #331 as commit 839986b, adding external-log dumping to the emitter and a public read-only log_filepath property.
stealth/space-bunny-alpha — closed resolved Merged an emitter API for writing external logs directly to its log file, bypassing terminal output, and added a public read-only log_filepath property.
stealth/space-bunny-alpha — closed resolved Merged PR #331, adding log dumping directly to the emitter’s log file and a public read-only log_filepath property, to support craft-application#691.
qwen/qwen3.6-35b-a3b — — Merged following approval by two reviewers and passing CI. Adds a log dumping function to route external logs directly to the emitter file instead of the terminal, plus a public read-only log_filepath property for easier access and testing.

Update history

No update history recorded yet.

Related work

Related issues

No related issues found above the similarity threshold.