← Back to issue list

fix: improve the handling of platforms errors.

View original Github issue

Metadata

Project
craft-application
Number
#706
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged fix for platform error handling. Approved by two reviewers with all CI checks passing. Resolves issue #690 and CRAFT-4369/4370. Modifies eight files with 98 additions and 239 deletions.

Suggested action:

No scores available.

Issue body

Fixes #690 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- CRAFT-4369, CRAFT-4370

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for platform error handling. Approved by two reviewers with all CI checks passing. Resolves issue #690 and CRAFT-4369/4370. Modifies eight files with 98 additions and 239 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged improvements to platform error handling, resolving issue #690 and CRAFT-4369/CRAFT-4370. The changes passed linting and tests before being successfully integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#947 feat!(platforms): prevent use of '/' in platform names craft-application merged Prevents use of '/' in platform names, resolving issue #941 and CRAFT-4876. Merged after approval by two reviewers and passing all CI checks across four modified files.
77%
#686 fix(ProjectService): better handling for invalid platforms craft-application merged Merged fix improving ProjectService invalid platform handling. Approved by two reviewers, passes CI, and updates the changelog. Incorporates targeted commits addressing review feedback from PR #683 across five files.
77%
#428 feat: tell the user which platforms matched when failing craft-application merged Implemented a feature to display matched platforms during failures. Merged after approval by three reviewers, the update modifies three files (+25/-6 lines) and resolves CRAFT-3107.
76%
#495 feat: add craft-platforms compatibility methods craft-application merged Merged after approval by two reviewers and passing CI checks. Added craft-platforms compatibility methods and deprecation warnings. Documentation breakage was later resolved in PR #498.
76%
#5205 refactor: use craft-platforms utilities snapcraft merged Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files.
75%
#516 commands/init: fix handling for platforms without pwd (CRAFT-496) charmcraft merged Merged fix for commands/init to handle platforms lacking the pwd module. Added Windows user information querying. Approved by two reviewers, modifying two files with 51 additions and 19 deletions.
74%
#2590 docs: add platform naming rules charmcraft merged Merged documentation update adding platform naming rules from craft-application. Approved by two reviewers. Integrated despite non-blocking CI test failures and type checker notifications.
73%
#94 fix: generate stricter default platforms debcraft merged Merged fix for issue #52 that generates stricter default platforms equivalent to Debian's any architecture value. Approved by two reviewers, passed all CI checks, and modified 10 files.
73%
#1130 docs: add platform naming rules rockcraft merged Merged documentation update adding platform naming rules from Craft Application. Approved by three reviewers with all CI checks passing. A noted merge conflict was resolved prior to final merge.
73%
#800 many: reword docstrings and code comments charmcraft merged Merged following single reviewer approval. Reworded docstrings and code comments across five files to improve clarity, resolving CRAFT-697. The +10/-10 line change passed all CI checks.
73%