fix(ProjectService): better handling for invalid platforms
Metadata
Current evaluation
Merged fix improving ProjectService invalid platform handling. Approved by two reviewers, passes CI, and updates the changelog. Incorporates targeted commits addressing review feedback from PR #683 across five files.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Response to https://github.com/canonical/craft-application/pull/683#discussion_r2005973548
Only the [last two commits](https://github.com/canonical/craft-application/pull/686/files/ad587613b9718389617ed4da30da1ddd7927a589..1778987ba68bc895a33932caaaf26371b7b5e9b4) are this PR, the rest are #683.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix improving ProjectService invalid platform handling. Approved by two reviewers, passes CI, and updates the changelog. Incorporates targeted commits addressing review feedback from PR #683 across five files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for ProjectService to improve invalid platform handling. Implemented via the final two commits after PR #683 feedback, with remaining concerns addressed separately. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #706 fix: improve the handling of platforms errors. | craft-application | merged | Merged fix for platform error handling. Approved by two reviewers with all CI checks passing. Resolves issue #690 and CRAFT-4369/4370. Modifies eight files with 98 additions and 239 deletions. | |
| #86 feat(project): add support to platforms in build plan | craft-application | merged | Implemented generic platform name filtering for build plans, resolving issue #83. Merged after reviewer approval and passing CI checks with 100% diff coverage. | |
| #867 feat(project): update Platform schema | rockcraft | merged | Merged, updating the Platform schema and superseding #862. Approved by two reviewers with 96 additions and 19 deletions across 16 files. The merge proceeded despite a failing OSV-scanner CI check. | |
| #5748 fix: get the project from the project service every time | snapcraft | merged | Merged a fix ensuring the project is retrieved from the project service on every call. Approved by two reviewers, the change modifies one file (+9/-1 lines) and resolves the retrieval logic despite one failing CI test. | |
| #2104 docs: update platforms reference | charmcraft | merged | Merged documentation update to the platforms reference, incorporating feedback from PR #2080. Approved by two reviewers with zero unresolved comments. Changed one file with 16 additions and 15 deletions. | |
| #94 fix: generate stricter default platforms | debcraft | merged | Merged fix for issue #52 that generates stricter default platforms equivalent to Debian's any architecture value. Approved by two reviewers, passed all CI checks, and modified 10 files. |