fix(ProjectService): better handling for invalid platforms
Metadata
Current evaluation
Merged PR #686 as commit 651f7573, improving ProjectService handling of invalid platforms and updating the changelog; changes originated from review feedback on #683.
Resolution: closed resolved
Reason: PR #686 was merged into the project as commit 651f7573, providing the invalid-platform handling fix and changelog update.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Response to https://github.com/canonical/craft-application/pull/683#discussion_r2005973548
Only the [last two commits](https://github.com/canonical/craft-application/pull/686/files/ad587613b9718389617ed4da30da1ddd7927a589..1778987ba68bc895a33932caaaf26371b7b5e9b4) are this PR, the rest are #683.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #686 as commit 651f7573, improving ProjectService handling of invalid platforms and updating the changelog; changes originated from review feedback on #683. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 651f7573, improving ProjectService handling of invalid platforms and updating the changelog. The change originated from review feedback on #683. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix improving ProjectService invalid platform handling. Approved by two reviewers, passes CI, and updates the changelog. Incorporates targeted commits addressing review feedback from PR #683 across five files. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#683
(confidence 100%)
The PR explicitly states that its changes came from review feedback on #683.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #86 feat(project): add support to platforms in build plan | craft-application | merged | Merged #86 added platform-name filtering for build plans, fixing #83; landed as commit e494797a. | |
| #706 fix: improve the handling of platforms errors. | craft-application | merged | Merged PR #706 as commit b61fcd58, improving platform-error handling and fixing internal errors for build-on configurations in #690. | |
| #2104 docs: update platforms reference | charmcraft | merged | Merged PR #2104 (commit 47f94098), updating the platforms reference with minor corrections from review feedback on #2080. |