← Back to issue list

feat(test): add more spread interactions

View original Github issue

Metadata

Project
craft-application
Number
#738
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after approval by two reviewers and passing CI. Adds --shell, --shell-after, and --debug lifecycle arguments to the test command, enabling specific test selection. Integrated with 441 additions across 12 files.

Suggested action:

No scores available.

Issue body

This adds the following lifecycle args to the test command: - --shell - --shell-after - --debug as well as allowing the user to specify one or more tests to run. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval by two reviewers and passing CI. Adds --shell, --shell-after, and --debug lifecycle arguments to the test command, enabling specific test selection. Integrated with 441 additions across 12 files.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds --shell, --shell-after, and --debug lifecycle arguments to the test command, enabling specific test selection. Supersedes #748.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#696 Add more spread interactions to the `test` command craft-application closed Completed via pull request #738. The test command now supports additional spread interactions like -debug and -shell-after, resolving the limitation.
82%
#763 fix(testing): handle spread interactive shell craft-application merged Merged a fix that pauses the emitter and disables stream capture during interactive spread shell tests, enabling terminal interaction without cluttering logs. Approved by two reviewers, passed all CI checks, and verified with Snapcraft.
76%
#1686 fix(test): parse test command arguments charmcraft merged Merged a fix updating the test command to parse arguments directly instead of forwarding them raw to spread. This enables consistent double-dashed long options and improved help messages. Approved by two reviewers, modifying five files with 55 additions and 32 deletions.
74%
#723 fix(testing): more intelligent test handling craft-application merged Merged after approval. Updates test handling to run spread tests as root and strictly parse top-level spread.yaml keys. Approved by two reviewers and passed CI checks before integration.
73%
#81 feat: implement --shell, shell-after, --debug craft-application merged Merged into main, implementing --shell, shell-after, and --debug flags. Approved by two reviewers, passed CI checks, and increased test coverage by 0.05%. Resolves issue #58.
71%
#1699 test: add a more complex platform example in spread charmcraft merged Merged a test update adding a more complex platform example to the spread test suite. The single-file change added three lines, received approval from two reviewers, and was integrated successfully.
70%
#1660 feat: add test command and templates charmcraft merged Merged addition of the charmcraft test command and templates. The feature invokes spread to run test suites locally and remotely using a multipass backend. Approved by two reviewers and rebased on main before integration.
70%
#13 test(spread): add more spread tests snapcraft-rocks merged Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines).
70%
#62 spread: add a "big" spread test rockcraft merged Merged a reusable spread test framework to house multiple checks without repeated setup. The initial test validates bug #44 regarding directory permissions. Approved by one reviewer and passed CI checks.
70%
#5366 feat: add 'test' command snapcraft merged Merged pull request introducing a new 'test' command. Approved by two reviewers, the change modified eight files with 170 additions and was successfully integrated into the repository.
70%