fix(testing): handle spread interactive shell
Metadata
Current evaluation
PR #763 merged as commit 1d5ed206: pauses the emitter and disables stream capture when running spread with --shell, --shell-after or --debug, so terminal interaction works (spread output no longer goes to the craft log).
Resolution: closed resolved
Reason: The PR was merged into craft-application main as commit 1d5ed206 ("fix(testing): handle spread interactive shell (#763)"), touching craft_application/services/testing.py. Approved by two reviewers and confirmed by cmatsuoka as tested with Snapcraft.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Pause the emitter and disable stream capture when running the test
command with `--shell`, `--shell-after` or `--debug`. This allows
terminal interaction with the spread shell, but the spread output is
not sent to the craft application log.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #763 merged as commit 1d5ed206: pauses the emitter and disables stream capture when running spread with --shell, --shell-after or --debug, so terminal interaction works (spread output no longer goes to the craft log). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-application#763 (commit 1d5ed206), pausing the emitter and disabling stream capture for --shell, --shell-after and --debug spread tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged fix makes spread testing interactive with --shell, --shell-after or --debug by pausing the emitter and disabling stream capture. Verified with Snapcraft. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix that pauses the emitter and disables stream capture during interactive spread shell tests, enabling terminal interaction without cluttering logs. Approved by two reviewers, passed all CI checks, and verified with Snapcraft. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#757
(confidence 45%)
Adjacent testing-UX fix in the same services/testing.py area preceding this change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #738 feat(test): add more spread interactions | craft-application | merged | Merged in PR #738 as commit 833ddfb9, adding specific test paths plus --shell, --shell-after, and --debug to the test command; released in 5.2.0. | |
| #696 Add more spread interactions to the `test` command | craft-application | closed | Feature request to expose spread options on `test` was implemented by merged PR #738 (commit 833ddfb9), adding test path selection plus --shell, --shell-after and --debug; shipped in craft-application 5.2.0. |