fix(testing): handle spread interactive shell
Metadata
Current evaluation
Merged a fix that pauses the emitter and disables stream capture during interactive spread shell tests, enabling terminal interaction without cluttering logs. Approved by two reviewers, passed all CI checks, and verified with Snapcraft.
Suggested action: —
No scores available.
Issue body
Pause the emitter and disable stream capture when running the test
command with `--shell`, `--shell-after` or `--debug`. This allows
terminal interaction with the spread shell, but the spread output is
not sent to the craft application log.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix that pauses the emitter and disables stream capture during interactive spread shell tests, enabling terminal interaction without cluttering logs. Approved by two reviewers, passed all CI checks, and verified with Snapcraft. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix that pauses the emitter and disables stream capture during spread interactive shell runs (--shell, --shell-after, --debug). This enables terminal interaction without cluttering application logs. Verified with Snapcraft. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #738 feat(test): add more spread interactions | craft-application | merged | Merged after approval by two reviewers and passing CI. Adds --shell, --shell-after, and --debug lifecycle arguments to the test command, enabling specific test selection. Integrated with 441 additions across 12 files. | |
| #696 Add more spread interactions to the `test` command | craft-application | closed | Completed via pull request #738. The test command now supports additional spread interactions like -debug and -shell-after, resolving the limitation. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged an improved snap inspector test that emulates system setup by stopping snapd, clearing device files, setting a global proxy, and restarting snapd to uncover network requests. Approved by two reviewers, passed all CI checks, and merged. | |
| #5389 test(spread): trace logs in spread tests | snapcraft | merged | Merged after approval. Added trace logging to spread tests. Despite CI failures from extra snapcraft output, the change was approved and merged following a related feature branch integration to prevent conflicts. | |
| #2381 tools: copy in spread-shellcheck from snapd | snapcraft | merged | Merged the spread-shellcheck tool from snapd to enable shellcheck integration for spread tests. Approved by reviewer, passed CI, and updated 74 files with 508 additions and 58 deletions. | |
| #347 Handle interactive terminal inside emitter stream context | craft-cli | open | Feature request to allow interactive terminal I/O (shell, debug) to escape output redirection when running inside an open_stream emitter context for craft test spread runs. Open 468 days with zero activity, no labels, no comments, no assignee. |