← Back to issue list

Ignore changes in `spread/` for lifecycle runs

View original Github issue

Metadata

Project
craft-application
Number
#756
Type
issue
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Resolved by PR #1383 (commit 11eddde0), alongside lifecycle fix PR #766 (cd6e8aa1), preventing spread changes from triggering needless rebuilds.

Resolution: closed resolved

Reason: PR #1383/commit 11eddde0 pulls ignored outdated spread files before version detection, keeping git describe accurate and avoiding false dirty states. This directly addresses the lifecycle rebuild problem in #756; PR #766 is the earlier related lifecycle fix.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Just like we ignore the packed artifacts themselves (like *.snap and *.rock in AppMetadata's `source_ignore_patterns`), we should also ignore changes in `spread/`, so that test changes don't cause a needless re-build of the artifact. This does mean that we're basically prohibiting `spread/` from being a part's source. ### Why it needs to get done So that test changes don't cause a needless re-build of the artifact.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Resolved by PR #1383 (commit 11eddde0), alongside lifecycle fix PR #766 (cd6e8aa1), preventing spread changes from triggering needless rebuilds.
stealth/space-bunny-alpha — closed resolved Spread/test-file changes no longer trigger needless rebuilds: PR #766 (cd6e8aa1) implemented the fix, later refined by PR #1383 (11eddde0).
stealth/space-bunny-alpha — closed resolved Fixed by PR #1383 (commit 11eddde0), which pulls ignored outdated files such as spread.yaml so git describe stays accurate and false dirty states do not trigger needless rebuilds.
qwen/qwen3.6-35b-a3b — — Ignoring spread/ directory changes during lifecycle runs to prevent unnecessary artifact rebuilds was closed without implementation. No resolution or linked pull request exists, indicating the feature was abandoned.
qwen/qwen3.6-35b-a3b — — Requesting that spread directory changes be ignored during lifecycle runs to prevent unnecessary rebuilds was closed without implementation. With zero comments and no linked pull request, it was abandoned.
qwen/qwen3.6-35b-a3b — — Abandoned. The request to ignore spread directory changes during lifecycle runs to prevent unnecessary rebuilds was closed without implementation.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: craft-application#1383 (confidence 99%)

    Issue data identifies this PR and commit as the resolving change for false dirty states caused by ignored spread files.

  • Related To: canonical/craft-application#766 (confidence 90%)

    Earlier lifecycle fix explicitly targeted preventing rebuilds caused by test-file changes.

Related issues

Issue Project State Summary Similarity
#766 fix(lifecycle): don't rebuild on test file changes craft-application merged Merged PR canonical/craft-application#766 excluded spread test files from lifecycle outdated checks, preventing test-only changes from repulling local source parts and resolving #756.
71%