fix(lifecycle): don't rebuild on test file changes
Metadata
Current evaluation
Merged PR canonical/craft-application#766 excluded spread test files from lifecycle outdated checks, preventing test-only changes from repulling local source parts and resolving #756.
Resolution: closed resolved
Reason: PR canonical/craft-application#766 was approved and merged with all reported CI checks passing. Its implementation added spread-related files to the outdated-file ignore list, directly resolving the behavior reported in #756.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Add spread files to the list of files ignored by the lifecycle manager
when checking if a part source is outdated. This allows changes in test
files without repulling the part when using local sources.
Fixes #756
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/craft-application#766 excluded spread test files from lifecycle outdated checks, preventing test-only changes from repulling local source parts and resolving #756. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged fix excludes spread test files from lifecycle outdated checks, so test-only changes no longer trigger rebuilding parts from local sources. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix that adds spread files to the lifecycle manager's ignore list, preventing unnecessary repulls when test files change. Approved by two reviewers, passed all CI checks, and resolves issue #756. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#756
(confidence 100%)
Issue #756 requested that spread test changes be ignored during lifecycle runs; PR #766 explicitly states that it fixes the issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1013 fix(LifecycleService): pull local test files | craft-application | merged | Merged craft-application#1013 (commit f4a4d282) fixed LifecycleService local-source handling: test files are copied without modifications triggering rebuilds; cryptography was also bumped for an OSV. | |
| #756 Ignore changes in `spread/` for lifecycle runs | craft-application | closed | Resolved by PR #1383 (commit 11eddde0), alongside lifecycle fix PR #766 (cd6e8aa1), preventing spread changes from triggering needless rebuilds. | |
| #251 feat(lifecycle)!: don't build on incompatible bases | craft-application | closed | Closed unmerged in favour of canonical/craft-application#263, which merged as commit b916620e adding the Lifecycle base/host compatibility check and fixing issue #154. | |
| #626 refactor: move the test command to lifecycle | craft-application | merged | Merged PR #626 moved testing into the lifecycle after pack and passed packed-artifact state to spread tests. |