fix(lifecycle): don't rebuild on test file changes
Metadata
Current evaluation
Merged fix that adds spread files to the lifecycle manager's ignore list, preventing unnecessary repulls when test files change. Approved by two reviewers, passed all CI checks, and resolves issue #756.
Suggested action: —
No scores available.
Issue body
Add spread files to the list of files ignored by the lifecycle manager
when checking if a part source is outdated. This allows changes in test
files without repulling the part when using local sources.
Fixes #756
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix that adds spread files to the lifecycle manager's ignore list, preventing unnecessary repulls when test files change. Approved by two reviewers, passed all CI checks, and resolves issue #756. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix adding spread test files to the lifecycle manager's ignore list, preventing unnecessary part repulls when local test files change. Resolves #756. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #892 fix(Lifecycle): don't cache the project | craft-application | merged | Merged a fix preventing project caching in the lifecycle module. Approved by two reviewers and passed all CI checks. The change modifies seven files and was validated via downstream snapcraft testing and passing spread tests. | |
| #4452 test(spread): check for new lifecycle message | snapcraft | merged | Merged a test update to verify a new lifecycle message, resolving a regression from #4431. Approved by two reviewers with passing CI and stable coverage. The fix unblocks PR #4450. | |
| #3719 tests: fix lifecycle tests to run on new directory | snapcraft | merged | Merged a fix for lifecycle tests to run in a new directory instead of the current one. Approved by a reviewer, passed CI, and changed three lines. | |
| #810 feat(lifecycle): only pack files if not already packed | craft-application | merged | Merged a lifecycle optimization that skips redundant file packing by verifying existing pack lists, prime timestamps, and file integrity. Approved by three reviewers and passed CI checks, successfully integrating the change. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #2669 tests: add reproducer for pack retaining deleted files between builds (#710) | charmcraft | open | Adds failing reproducer test for #710 plus a fix (PartsLifecycle._clean_stale_parts) that cleans stale pulled files before each lifecycle run; test now passes. Awaiting review; several CI checks failing. | |
| #3024 tests: remove usage of FakeApt fixtures in lifecycle | snapcraft | merged | Merged changes replacing FakeApt fixtures in lifecycle tests with targeted mock.patch calls and related cleanup. Approved by one reviewer and passed CI checks. | |
| #1013 fix(LifecycleService): pull local test files | craft-application | merged | Merged following successful CI checks and approvals. Resolves #942 by fixing LifecycleService to pull local test files, updates the cryptography dependency, and adds verification tests. Unblocks snapcraft issue #5831. |