← Back to issue list

fix(application)!: drop unused set_global_environment

View original Github issue

Metadata

Project
craft-application
Number
#762
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR to drop unused Application._set_global_environment was closed unmerged after going stale; it was superseded by PR #1078 (commit 3334f13e), which removed the deprecated API in the next major release.

Resolution: closed superseded

Reason: The author closed the PR on 2025-09-08 noting it was outdated and that removing all deprecated functions at the next major release would be easier than resurrecting it. That plan was executed by merged PR #1078 (commit 3334f13e, "chore!: remove deprecated APIs"), whose changelog entry records that Application._set_global_environment() is removed in favour of ProjectService.update_project_environment().

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- `application._set_global_environment()` was replaced by `services.project.update_project_environment()` but the now unused function still persists in craft-application.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR to drop unused Application._set_global_environment was closed unmerged after going stale; it was superseded by PR #1078 (commit 3334f13e), which removed the deprecated API in the next major release.
stealth/space-bunny-alpha — closed superseded Closed unmerged; broader PR #1078 later removed the deprecated API during the next major-release cleanup in commit 3334f13e.
qwen/qwen3.6-35b-a3b — — Closed without merging. The author superseded this cleanup, opting to remove all deprecated functions in a single PR during the next major release rather than resurrecting this outdated change.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-application#1078 (confidence 95%)

    Merged major-release cleanup commit 3334f13e removed _set_global_environment, as announced in the closing comment.

  • Related To: canonical/craft-application#768 (confidence 80%)

    Commit 3bb1c968 first marked _set_global_environment deprecated instead of removing it, leaving the removal to a later major.

  • Caused By: canonical/craft-application#646 (confidence 70%)

    Commit 16a20e36 added the project service that replaced the method, rendering it unused.

Related issues

Issue Project State Summary Similarity
#768 fix: mark Application._set_global_environment as deprecated craft-application merged Merged in #768 via 3bb1c968, deprecating Application._set_global_environment; #1078 later removed it in the next major release.
84%