← Back to issue list

fix(application)!: drop unused set_global_environment

View original Github issue

Metadata

Project
craft-application
Number
#762
Type
pull request
State
closed
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Closed without merging. The author superseded this cleanup, opting to remove all deprecated functions in a single PR during the next major release rather than resurrecting this outdated change.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- `application._set_global_environment()` was replaced by `services.project.update_project_environment()` but the now unused function still persists in craft-application.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without merging. The author superseded this cleanup, opting to remove all deprecated functions in a single PR during the next major release rather than resurrecting this outdated change.
qwen3.6-35b-a3b-mtp-q6 Superseded and abandoned. The unused function will be removed alongside other deprecated functions in a single PR during the next major release.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#768 fix: mark Application._set_global_environment as deprecated craft-application merged Merged PR deprecates Application._set_global_environment to avoid breaking changes after being missed in v5.0. Kept as dead code until the next major release, with removal planned for v6.0. Approved and passed all CI checks.
75%