fix: mark Application._set_global_environment as deprecated
Metadata
Current evaluation
Merged PR deprecates Application._set_global_environment to avoid breaking changes after being missed in v5.0. Kept as dead code until the next major release, with removal planned for v6.0. Approved and passed all CI checks.
Suggested action: —
No scores available.
Issue body
I should have removed this in 5.0 but overlooked it, so we're stuck with it until the next major release. It's essentially dead code though.
Removal PR for 6.0 is at https://github.com/canonical/craft-application/pull/762
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged PR deprecates Application._set_global_environment to avoid breaking changes after being missed in v5.0. Kept as dead code until the next major release, with removal planned for v6.0. Approved and passed all CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to mark Application._set_global_environment as deprecated. Overlooked removal in v5.0 would break existing code, so the method remains until v6.0. PR #762 handles the eventual removal. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #762 fix(application)!: drop unused set_global_environment | craft-application | closed | Closed without merging. The author superseded this cleanup, opting to remove all deprecated functions in a single PR during the next major release rather than resurrecting this outdated change. |