fix: mark Application._set_global_environment as deprecated
Metadata
Current evaluation
Merged in #768 via 3bb1c968, deprecating Application._set_global_environment; #1078 later removed it in the next major release.
Resolution: closed resolved
Reason: PR #768 was approved and merged as commit 3bb1c968, preserving compatibility while deprecating the unused method. The initially proposed removal PR #762 closed unmerged, and #1078 later removed the API in commit 3334f13e.
Evaluated by: mr-cal-bot
No scores available.
Issue body
I should have removed this in 5.0 but overlooked it, so we're stuck with it until the next major release. It's essentially dead code though.
Removal PR for 6.0 is at https://github.com/canonical/craft-application/pull/762
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in #768 via 3bb1c968, deprecating Application._set_global_environment; #1078 later removed it in the next major release. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged via commit 3bb1c968; marks Application._set_global_environment deprecated (changelog 5.3.0). Later removed in 6.0 by PR #1078 (3334f13e), which superseded the earlier unmerged removal PR #762. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #768 via commit 3bb1c968, deprecating Application._set_global_environment while retaining it for compatibility until the next major release. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged PR deprecates Application._set_global_environment to avoid breaking changes after being missed in v5.0. Kept as dead code until the next major release, with removal planned for v6.0. Approved and passed all CI checks. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#762
(confidence 100%)
Proposed removal of the deprecated method, but closed unmerged.
-
Superseded By:
canonical/craft-application#1078
(confidence 100%)
Merged major-release cleanup removed the deprecated API in commit 3334f13e.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #762 fix(application)!: drop unused set_global_environment | craft-application | closed | PR to drop unused Application._set_global_environment was closed unmerged after going stale; it was superseded by PR #1078 (commit 3334f13e), which removed the deprecated API in the next major release. |