← Back to issue list

Additional proxies not accounted for in tests

View original Github issue

Metadata

Project
craft-application
Number
#777
Type
issue
State
closed
Author
bepri
Labels
Status: Triaged Type: Bug
Created
Updated
Closed

Current evaluation

Fixed by merged PR #765 (commit 42945e65), which made provider environment tests tolerate additional proxy-related variables.

Resolution: closed resolved

Reason: PR #765 was merged as commit 42945e65. Maintainer lengau explicitly confirmed that craft-application#777 was fixed by that PR.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description Unit tests for the provider service assume a strict set of proxies, no more no less. Certain environments may have other environment variables with the "`x_proxy`" naming scheme, which breaks the test. ### To Reproduce `MY_PROXY="woah" uv run pytest -k test_setup_proxy_environment` ### part yaml ```shell ``` ### Relevant log output ```shell https://github.com/canonical/craft-application/actions/runs/15494973818/job/43629397369?pr=773#step:8:1081 ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #765 (commit 42945e65), which made provider environment tests tolerate additional proxy-related variables.
stealth/space-bunny-alpha — closed resolved Resolved by merged PR #765 (commit 42945e65), fixing provider-service test failures caused by extra x_proxy environment variables.
qwen/qwen3.6-35b-a3b — — Unit tests failed when extra proxy environment variables were present. The bug was fixed by updating the test logic to handle additional proxies, with the resolution merged in pull request #765.
qwen/qwen3.6-35b-a3b — — Unit tests failing on additional x_proxy environment variables were fixed in pull request #765. The issue is now closed.
qwen/qwen3.6-35b-a3b — — Fixed in PR #765. The unit tests for the provider service were updated to handle additional environment variables with the 'x_proxy' naming scheme, resolving the issue where strict proxy assumptions caused test failures in certain environments.

Update history

No update history recorded yet.

Related work

Related issues

No related issues found above the similarity threshold.