feat: pass config values to the inner instance as environment variables
Metadata
Current evaluation
Merged PR #765 as commit 42945e65, passing config values to the inner instance via environment variables and fixing #777 by accounting for extra proxy variables in tests.
Resolution: closed resolved
Reason: PR #765 merged into the project as commit 42945e65. Its change also closed issue #777 by making provider environment tests tolerate additional proxy-related variables.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
As a drive-by, fixes #777
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #765 as commit 42945e65, passing config values to the inner instance via environment variables and fixing #777 by accounting for extra proxy variables in tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged config propagation into the inner instance as environment variables. Approved despite test failures that lengau linked to craft-application#778. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #765 as commit 42945e65, passing config values to the inner instance via environment variables and fixing #777; remaining test gaps were addressed separately in #778. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged by maintainer lengau, this change passes config values to the inner instance as environment variables and resolves #777. It was merged despite failing slow tests, deferred to a separate tracking PR. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-application#777
(confidence 98%)
Issue explicitly identified as fixed by the changes in PR #765.
-
Related To:
canonical/craft-application#778
(confidence 95%)
Maintainer said the remaining test failure was addressed by PR #778.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #260 feat: pass environment variables to the instance. | craft-application | merged | Merged PR #260 as commit c70425d9, forwarding proxy variables to the provider and demonstrating application-defined instance variables; fixes #258 (CRAFT-2579). | |
| #921 feat: forward environment variable to inner instance | craft-application | closed | PR #921 was closed unmerged so environment-variable and related variable work could be consolidated elsewhere. |