← Back to issue list

fix(init): exit parent template dir context after using it

View original Github issue

Metadata

Project
craft-application
Number
#795
Type
pull request
State
open
Author
jonathan-conder
Labels
Created
Updated
Closed

Current evaluation

Fix init command to keep parent template dir context active during use; changes requested by 2 reviewers with 8 unresolved comments, no author response in ~10 months, CI failing on test jobs.

Suggested action: close stale

Reason: Review status is changes_requested from 2 reviewers with 8 unresolved comments and last activity was 301 days ago, well past the 3-month threshold for unaddressed maintainer feedback. The underlying bug (importlib.resources.path context manager exiting before the path is used in craft_application/commands/init.py) still exists in the codebase, but the PR has been abandoned by its author.

Impact: 45 Quick Win: 29.25 Staleness: 78 Complexity: 35 Confidence: 72

Issue body

The directory isn't guaranteed to exist after the context manager exits. --- - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- There were some unrelated lint/test failures.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 45
Quick Win: 29.25
Staleness: 78
Complexity: 35
Confidence: 72
close stale Fix init command to keep parent template dir context active during use; changes requested by 2 reviewers with 8 unresolved comments, no author response in ~10 months, CI failing on test jobs.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 20
Confidence: 75
close stale Addresses directory context manager exit in init template. Currently has 8 unresolved review comments, failing CI tests, and no activity for 261 days.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 15
Confidence: 85
close stale Fixes improper exit from parent template directory context. PR is inactive for over 8 months, lacks maintainer feedback, and author hasn't run required lint/tests.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 15
Confidence: 60
needs review Fixes a bug where the parent template directory context manager fails to exit properly after use, as the directory may not exist. The pull request remains open with no comments or activity for 225 days, awaiting review and lint fixes.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.