← Back to issue list

feat(lifecycle): only pack files if not already packed

View original Github issue

Metadata

Project
craft-application
Number
#810
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in commit baf92c81: lifecycle packing now skips unnecessary repacks by tracking packed files and prime-state timestamps.

Resolution: closed resolved

Reason: PR #810 was approved and merged as commit baf92c81. It repacks only when the packed-file list is absent, artifacts are outdated, or a tracked file is missing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Keep a list of packed files and use it to check if repacking is necessary, according to the following logic: 1. Before packing, check if the list file exists. If not, we never packed before and packing is necessary. 2. Check the most recent prime state timestamp. These are generated when parts are primed. If any part was primed after the artifacts were generated, we need to pack again. 4. If any previously packed file is missing, we repack everything. 5. Otherwise, the existing files are up-to-date and repacking is not required. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in commit baf92c81: lifecycle packing now skips unnecessary repacks by tracking packed files and prime-state timestamps.
stealth/space-bunny-alpha — closed resolved Merged #810 in baf92c81, skipping unnecessary lifecycle repacking by tracking packed files and prime-state timestamps; missing lists or files trigger a full repack.
qwen/qwen3.6-35b-a3b — — Merged a lifecycle optimization that skips redundant file packing by verifying existing pack lists, prime timestamps, and file integrity. Approved by three reviewers and passed CI checks, successfully integrating the change.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#237 feat(lifecycle): always track stage packages craft-application merged Merged craft-application PR #237 as commit 27465d88, making lifecycle managers always track stage packages.
71%
#52 lifecycle: emit progress for packing craft-application merged PR #52 merged into main (commit a613d538), adding lifecycle progress emission during packing to avoid a long silent ticker on the Lifecycle completion message.
70%